[Security Solution][Exception]: Add to shared lists fixes #146750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WafaaNasr
added
release_note:skip
WafaaNasr
commented
Dec 1, 2022
| @@ -425,7 +425,7 @@ export const AddExceptionFlyout = memo(function AddExceptionFlyout({ | |||
| return ( | |||
| <EuiFlyout | |||
| ownFocus | |||
| maskProps={{ style: 'z-index: 5000' }} // For an edge case to display above the timeline flyout | |||
| maskProps={{ style: 'z-index: 1000' }} // For an edge case to display above the timeline flyout | |||
There was a problem hiding this comment.
Adding this line for testing the PR on then Cloud env, then will revert it back until we fix it
There was a problem hiding this comment.
reverted back 208a29e after testing
nkhristinin
approved these changes
Dec 2, 2022
| ...rest | ||
| }) => ({ | ||
| ...rest, | ||
| namespace_type: namespaceType ?? 'single', |
There was a problem hiding this comment.
Why do we need this transformation?
There was a problem hiding this comment.
What I understood is that in order to send namespacetype: single by default, if the list.namespace had a falsy value and in order to do so in the tsx if we used the snack case we will receive the below error
Parameter name namespace_type must match one of the following formats: camelCase, PascalCase
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @WafaaNasr |
kibanamachine
pushed a commit
that referenced
this pull request
Dec 2, 2022
## Summary - Continuing from [PR](#146121) to apply the same changes to the `Add to Shared Lists`. - Fix showing the number of Linked rules correctly => in `route.ts` use the `list.namespaceType` instead of namespaceTypes array - Apply docs comment on the text - Use the HeaderMenu item from the `kbn` package for the `Number of Linked rules` menu - Allow displaying the HeaderMenu without iconType - Update snapshots and add tests in HeaderMenu (cherry picked from commit 78b4851)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
WafaaNasr
added a commit
that referenced
this pull request
Dec 2, 2022
) (#146887) # Backport This will backport the following commits from `main` to `8.6`: - [[Security Solution][Exception]: Add to shared lists fixes (#146750)](#146750) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Wafaa Nasr","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-12-02T14:02:33Z","message":"[Security Solution][Exception]: Add to shared lists fixes (#146750)\n\n## Summary\r\n\r\n- Continuing from [PR](#146121) to\r\napply the same changes to the `Add to Shared Lists`.\r\n- Fix showing the number of Linked rules correctly => in `route.ts` use\r\nthe `list.namespaceType` instead of namespaceTypes array\r\n- Apply docs comment on the text\r\n- Use the HeaderMenu item from the `kbn` package for the `Number of\r\nLinked rules` menu\r\n- Allow displaying the HeaderMenu without iconType\r\n- Update snapshots and add tests in HeaderMenu","sha":"78b4851a214e5018c8ea6535477ca9374ffb377f","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","auto-backport","Team:Security Solution Platform","ci:cloud-deploy","v8.6.0"],"number":146750,"url":"https://github.com/elastic/kibana/pull/146750","mergeCommit":{"message":"[Security Solution][Exception]: Add to shared lists fixes (#146750)\n\n## Summary\r\n\r\n- Continuing from [PR](#146121) to\r\napply the same changes to the `Add to Shared Lists`.\r\n- Fix showing the number of Linked rules correctly => in `route.ts` use\r\nthe `list.namespaceType` instead of namespaceTypes array\r\n- Apply docs comment on the text\r\n- Use the HeaderMenu item from the `kbn` package for the `Number of\r\nLinked rules` menu\r\n- Allow displaying the HeaderMenu without iconType\r\n- Update snapshots and add tests in HeaderMenu","sha":"78b4851a214e5018c8ea6535477ca9374ffb377f"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Wafaa Nasr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add to Shared Lists.route.tsuse thelist.namespaceTypeinstead of namespaceTypes arraykbnpackage for theNumber of Linked rulesmenu