Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix beta badge alignment #146267

Merged
merged 3 commits into from
Nov 25, 2022
Merged

[Discover] Fix beta badge alignment #146267

merged 3 commits into from
Nov 25, 2022

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Nov 24, 2022 •
edited
Loading

@dimaanj dimaanj added Feature:Discover Discover Application release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Nov 24, 2022
@dimaanj dimaanj self-assigned this Nov 24, 2022
@dimaanj dimaanj mentioned this pull request Nov 24, 2022
Closed
jughosta
jughosta approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@jughosta jughosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dimaanj
Copy link
Contributor Author

dimaanj commented Nov 24, 2022

@elasticmachine merge upstream

@dimaanj dimaanj marked this pull request as ready for review November 24, 2022 12:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal
kertal approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx for making it pretty again! just wanted to mention, it doesn't need to be labeled as a fix, since it hasn't escaped into the wilderness since 8.6 has not been released, right?

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 415.0KB 415.1KB +60.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 442 448 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 109 115 +6
securitySolution 519 525 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dimaanj

@dimaanj dimaanj merged commit 0a3b9e4 into elastic:8.6 Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jughosta jughosta jughosta approved these changes

@kertal kertal kertal approved these changes

Assignees

@dimaanj dimaanj

Labels
Feature:Discover Discover Application release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dimaanj @elasticmachine @kibana-ci @kertal @jughosta @kibanamachine