Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Fix beta badge alignment #145963

Closed
wants to merge 2 commits into from

Conversation

dimaanj
Copy link
Contributor

@dimaanj dimaanj commented Nov 22, 2022

Summary

Closes #144655

This PR is intended to be backported to v8.6. It can be tested by running could instance and applying vertical-align: middle; to the element styles.
https://staging.found.no/home

@dimaanj dimaanj added Feature:Discover Discover Application release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.6.0 v8.7.0 labels Nov 22, 2022
@dimaanj dimaanj self-assigned this Nov 22, 2022
@dimaanj dimaanj marked this pull request as ready for review November 23, 2022 15:42
@dimaanj dimaanj requested a review from a team as a code owner November 23, 2022 15:42
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@dimaanj
Copy link
Contributor Author

dimaanj commented Nov 23, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 415.1KB 415.1KB -4.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 68 74 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dimaanj

Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't pulled to test, but I'm not sure I understand what these changes do. Does moving the CSS block outside the component have an impact?

@dimaanj
Copy link
Contributor Author

dimaanj commented Nov 24, 2022

Closing it, since #146267 created.

@dimaanj dimaanj closed this Nov 24, 2022
@dimaanj
Copy link
Contributor Author

dimaanj commented Nov 24, 2022

I haven't pulled to test, but I'm not sure I understand what these changes do. Does moving the CSS block outside the component have an impact?

I was initating the changes in 8.7 just to trigger backport for 8.6, since this css block does not exists in prev minor. but decided to create separate #146267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:fix Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.6.0 v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discover] Field statistics beta badge is misaligned
5 participants