Bumping EUI to v70.4.0 #145888

1Copenut · 2022-11-21T16:12:50Z

[email protected] ⏩ [email protected]

"Fixed EuiButtonGroup firing onChange twice" required changing some tests from click to change

`70.4.0`

Updated EuiTourStep.footerAction type to accept ReactNode[] (#6384)
Vertically aligned all footer content so that euiTourStepIndicator is always centered (#6384)
Added filterInCircle glyph to EuiIcon (#6385)
Added color prop to EuiBeacon (#6420)
Added the euiMaxBreakpoint and euiMinBreakpoint CSS-in-JS utilities for creating min/max-width media queries (#6431)

Bug fixes

Restores the previous match operator behaviour when the query value is split into multiple terms after analysis. (#6409)
Fixed missing slide-in animation on EuiCollapsibleNavs and left-side EuiFlyouts (#6422)
Fix bug in EuiCard where footer were not aligned to the bottom of the card (#6424)
Fixed multiple component media queries for consumers with custom theme breakpoints (#6431)

`70.3.0`

EuiSearchBar now automatically wraps special characters not used by query syntax in quotes (#6356)
Added alignment prop to EuiBetaBadge (#6361)
EuiButton now accepts minWidth={false} (#6373)

Bug fixes

Fixed EuiPageTemplate not correctly passing the component prop to the inner main content wrapper. (#6352)
EuiSkipLink now correctly calls onClick even when fallbackDestination is invalid (#6355)
Permanently fixed EuiModal to not cause scroll-jumping issues on modal open (#6360)
Re-fixed EuiPageSection not correctly merging contentProps.css (#6365)
Fixed EuiTab not defaulting to size m (#6366)
Fixed the shadow sizes of .eui-yScrollWithShadows and .eui-xScrollWithShadows (#6374)
Fixed bug in EuiCard where the inner content in vertical cards was not growing 100% in width (#6377)
Fixed incorrect margins in EuiSuperDatePicker caused by EuiFlex CSS gap change (#6380)
Fixed visual bug in nested EuiFlexGroups, where the parent EuiFlexGroup is responsive but a child EuiFlexGroup is not (#6381)

CSS-in-JS conversions

Converted EuiModal to Emotion (#6321)

Fixes

EuiButton no longer outputs unnecessary inline styles for minWidth={0} or minWidth={false} (#6373)
EuiFacetButton no longer reports type issues when passing props accepted by EuiButton (#6373)

…feature/eui-70.3.0

- CI/tests were failing because the blur events were fighting one another and causing focus to be lost when clicking between password fields

afharo

Core changes LGTM

cnasikas

ResponseOps changes LGTM

alisonelizabeth

Left one question about a test change for Deployment Management

x-pack/plugins/index_management/__jest__/components/index_table.test.js

michaelolo24

Threat hunting investigations changes. LGTM!

package.json

..._management/public/application/sections/license_dashboard/revert_to_basic/revert_to_basic.js

tsullivan

Global Exp changes LGTM

…s H1.

cee-chen

🎉 Woohoo! Nice to have a smaller upgrade for a change.

alisonelizabeth

Deployment Management changes LGTM

paul-tavares

LGTM - on behalf of @elastic/security-onboarding-and-lifecycle-mgt

kc13greiner

LGTM!

kibana-ci · 2022-12-01T19:07:27Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`infra`	1.1MB	1.1MB	+912.0B
`licenseManagement`	63.4KB	63.3KB	-20.0B
`security`	549.5KB	549.6KB	+124.0B
`visTypeVega`	1.8MB	1.8MB	+912.0B
total			+1.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`kbnUiSharedDeps-css`	343.8KB	340.5KB	-3.4KB
`kbnUiSharedDeps-npmDll`	5.2MB	5.2MB	+7.1KB
total			+3.7KB

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`osquery`	1	2	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	59	65	+6
`osquery`	109	115	+6
`securitySolution`	442	448	+6
total			+20

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	68	74	+6
`osquery`	110	117	+7
`securitySolution`	519	525	+6
total			+21

History

💛 Build #92129 was flaky ee34833
💔 Build #91575 failed 6da1228
💔 Build #91536 failed 016b979
💚 Build #91105 succeeded 5389257
💚 Build #90484 succeeded d1c8e3a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @1Copenut

Bumping EUI to v70.3.0

db246ea

1Copenut added release_note:skip Skip the PR/issue when compiling release notes EUI ci:cloud-deploy Create or update a Cloud deployment v8.7.0 labels Nov 21, 2022

1Copenut self-assigned this Nov 21, 2022

1Copenut and others added 12 commits November 21, 2022 11:09

Updating three snapshot tests.

bd4de15

Updated data-test-subj to current confirm modal string.

8c8f86a

Updated one confirm modal data-test-subj string.

05cba26

Updating class euiModal count from 1 to 2.

75cb55f

Updating four more snapshot tests.

03ca3d2

Updating one snapshot, one CSS selector for find method.

542d3ed

Merge branch 'main' into feature/eui-70.3.0

8972721

Bumping react-focus-on to 3.7.0 to match EUI.

3628895

Merge branch 'feature/eui-70.3.0' of github.com:1Copenut/kibana into …

0297330

…feature/eui-70.3.0

Wrapping confirm title in DIV to restore test.

85f481d

Add blur workaround to password change modal

6c80355

- CI/tests were failing because the blur events were fighting one another and causing focus to be lost when clicking between password fields

Bumping EUI to 70.4.0.

8c90cd8

1Copenut changed the title ~~[DO NOT MERGE] Bumping EUI to v70.3.0~~ [DO NOT MERGE] Bumping EUI to v70.4.0 Nov 23, 2022

Updating 1 unit test for EuiTourStep types.

d1c8e3a

1Copenut marked this pull request as ready for review November 23, 2022 22:01

1Copenut requested review from a team as code owners November 23, 2022 22:01

afharo approved these changes Nov 24, 2022

View reviewed changes

cnasikas approved these changes Nov 26, 2022

View reviewed changes

alisonelizabeth reviewed Nov 28, 2022

View reviewed changes

x-pack/plugins/index_management/__jest__/components/index_table.test.js Outdated Show resolved Hide resolved

jbudz approved these changes Nov 28, 2022

View reviewed changes

Updated modal selector to be more exclusive.

5389257

cee-chen mentioned this pull request Nov 28, 2022

[Security Solution]Blank page shown on opening session from bottom of alert list #141917

Closed

ryankeairns mentioned this pull request Nov 28, 2022

[Discover] Field statistics beta badge is misaligned #144655

Closed

michaelolo24 approved these changes Nov 29, 2022

View reviewed changes

1Copenut requested a review from alisonelizabeth November 29, 2022 17:48

drewdaemon approved these changes Nov 29, 2022

View reviewed changes

cee-chen reviewed Nov 29, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

Merge branch 'main' into feature/eui-70.3.0

e61e97b

cee-chen reviewed Nov 29, 2022

View reviewed changes

..._management/public/application/sections/license_dashboard/revert_to_basic/revert_to_basic.js Outdated Show resolved Hide resolved

tsullivan approved these changes Nov 29, 2022

View reviewed changes

1Copenut added 2 commits November 29, 2022 12:11

Set the correct version delimiter for react-focus-on

32ec4cd

Refactored FormattedMessage to raw i18n so modal title would render a…

016b979

…s H1.

cee-chen approved these changes Nov 29, 2022

View reviewed changes

alisonelizabeth approved these changes Nov 29, 2022

View reviewed changes

paul-tavares approved these changes Nov 29, 2022

View reviewed changes

Merge branch 'main' into feature/eui-70.3.0

6da1228

kc13greiner approved these changes Nov 29, 2022

View reviewed changes

1Copenut added 2 commits December 1, 2022 09:47

Merge branch 'main' into feature/eui-70.3.0

ee34833

Merge branch 'main' into feature/eui-70.3.0

80ef488

nkhristinin approved these changes Dec 2, 2022

View reviewed changes

1Copenut merged commit 7376d9c into elastic:main Dec 2, 2022

kibanamachine added the backport:skip This commit does not require backporting label Dec 2, 2022

1Copenut deleted the feature/eui-70.3.0 branch December 2, 2022 14:17

thomheymann mentioned this pull request Dec 5, 2022

Unable to filter users from domain in API keys #143079

Closed

nreese mentioned this pull request Jan 18, 2023

Save modal dark theme issues in Discover, Dashboard, and Maps #149130

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bumping EUI to v70.4.0 #145888

Bumping EUI to v70.4.0 #145888

1Copenut commented Nov 21, 2022 •

edited

Loading

afharo left a comment

cnasikas left a comment

alisonelizabeth left a comment

michaelolo24 left a comment

tsullivan left a comment

cee-chen left a comment

alisonelizabeth left a comment

paul-tavares left a comment

kc13greiner left a comment

kibana-ci commented Dec 1, 2022 •

edited

Loading

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

Bumping EUI to v70.4.0 #145888

Bumping EUI to v70.4.0 #145888

Conversation

1Copenut commented Nov 21, 2022 • edited Loading

70.4.0

70.3.0

afharo left a comment

Choose a reason for hiding this comment

cnasikas left a comment

Choose a reason for hiding this comment

alisonelizabeth left a comment

Choose a reason for hiding this comment

michaelolo24 left a comment

Choose a reason for hiding this comment

tsullivan left a comment

Choose a reason for hiding this comment

cee-chen left a comment

Choose a reason for hiding this comment

alisonelizabeth left a comment

Choose a reason for hiding this comment

paul-tavares left a comment

Choose a reason for hiding this comment

kc13greiner left a comment

Choose a reason for hiding this comment

kibana-ci commented Dec 1, 2022 • edited Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

1Copenut commented Nov 21, 2022 •

edited

Loading

`70.4.0`

`70.3.0`

kibana-ci commented Dec 1, 2022 •

edited

Loading