Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save modal dark theme issues in Discover, Dashboard, and Maps #149130

Closed
nreese opened this issue Jan 18, 2023 · 2 comments · Fixed by #149147
Closed

Save modal dark theme issues in Discover, Dashboard, and Maps #149130

nreese opened this issue Jan 18, 2023 · 2 comments · Fixed by #149147
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. regression Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.7.0

Comments

@nreese
Copy link
Contributor

nreese commented Jan 18, 2023 •
edited
Loading

Screen Shot 2023-01-18 at 7 50 55 AM

Discover, Dashboard, and Maps use showSaveModal to show save modal. showSaveModal does not properly wrap new React tree in KibanaThemeProvider.

Regression caused in v8.7.0 by #145888. Eui update 70.3.0 contained conversion of EuiModal to emotion. The emotion conversion causes EuiModal to pull styles from emotion theming , resulting in the regression.
Screen Shot 2023-01-18 at 7 56 50 AM

I am working on putting up a fix for all uses of showSaveModal by requiring showSaveModal to take theme and wrap modal in KibanaThemeProvider.
@nreese nreese added bug Fixes for quality problems that affect the customer experience regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0 labels Jan 18, 2023
@nreese nreese self-assigned this Jan 18, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@nreese nreese mentioned this issue Jan 18, 2023
Merged
@nreese nreese closed this as completed in d5f6fe8 Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. regression Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix 'Save modal dark theme issues in Discover, Dashboard, and Maps' nreese/kibana
2 participants
@nreese @elasticmachine