Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Unskips functional tests and fixes flakiness #145804

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Nov 21, 2022

Summary

Closes #145563
Closes #145562
Closes #145561
Closes #145560
Closes #145644
Closes #139096
Closes #145564

They also fail for the same reason in FF. They started fail when a change made by the operations team.

For some reason while the list appears on the DOM the click by mouse doesn't work for the FF tests. I changed the helper a bit to not use it.
image

Runner for tests (50 times) to ensure that nothing has broken https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1577#_

I couldn't run the firefox tests on the flaky runner (I get an error when initializing it) but these tests were failing every time we run them on FF locally I am quite optimistic that this change will stabilize them in FF too.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 442 448 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 110 117 +7
securitySolution 519 525 +6
total +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula added failed-test A test failure on a tracked branch, potentially flaky-test release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 21, 2022
@stratoula stratoula marked this pull request as ready for review November 21, 2022 09:06
@stratoula stratoula requested a review from a team as a code owner November 21, 2022 09:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@stratoula stratoula changed the title [TSVB] Unskips functional tests and fix flakiness [TSVB] Unskips functional tests and fixes flakiness Nov 21, 2022
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

@stratoula stratoula merged commit ba67a66 into elastic:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting failed-test A test failure on a tracked branch, potentially flaky-test Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test: Firefox UI Functional Tests.test/functional/apps/visualize/group5/_tsvb_time_series·ts - visualize app visual builder Time Series Elastic charts Hiding series should hide series by legend item click Failing test: Firefox UI Functional Tests.test/functional/apps/visualize/group5/_tsvb_time_series·ts - visualize app visual builder Time Series Elastic charts should display correct chart data, label names and area colors for min aggregation when split by filters Failing test: Firefox UI Functional Tests.test/functional/apps/visualize/group5/_tsvb_time_series·ts - visualize app visual builder Time Series Elastic charts should display correct chart data, label names and area colors for sum aggregation when split by terms Failing test: Firefox UI Functional Tests.test/functional/apps/visualize/group5/_tsvb_time_series·ts - visualize app visual builder Time Series basics Clicking on the chart should create a filter Failing test: Firefox UI Functional Tests.test/functional/apps/visualize/group5/_tsvb_time_series·ts - visualize app visual builder Time Series basics Clicking on the chart should create a filter for series with multiple split by terms fields one of which has formatting
5 participants