Skip to content

Commit

Permalink
[TSVB] Unskips functional tests and fixes flakiness (#145804)
Browse files Browse the repository at this point in the history
## Summary

Closes #145563
Closes #145562
Closes #145561
Closes #145560
Closes #145644
Closes #139096
Closes #145564

They also fail for the same reason in FF. They started fail when a
change made by the operations team.

For some reason while the list appears on the DOM the click by mouse
doesn't work for the FF tests. I changed the helper a bit to not use it.

![image](https://user-images.githubusercontent.com/17003240/202997107-1ddcfd69-c935-4d0a-891f-1feb9d00ebb5.png)

Runner for tests (50 times) to ensure that nothing has broken
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1577#_

I couldn't run the firefox tests on the flaky runner (I get an error
when initializing it) but these tests were failing every time we run
them on FF locally I am quite optimistic that this change will stabilize
them in FF too.
  • Loading branch information
stratoula authored Nov 21, 2022
1 parent 87c64dd commit ba67a66
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
5 changes: 1 addition & 4 deletions test/functional/apps/visualize/group5/_tsvb_time_series.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,7 @@ export default function ({ getPageObjects, getService }: FtrProviderContext) {
const browser = getService('browser');
const kibanaServer = getService('kibanaServer');

// Failing: See https://github.com/elastic/kibana/issues/145563
// Failing: See https://github.com/elastic/kibana/issues/145560
// Failing: See https://github.com/elastic/kibana/issues/139096
describe.skip('visual builder', function describeIndexTests() {
describe('visual builder', function describeIndexTests() {
before(async () => {
await security.testUser.setRoles([
'kibana_admin',
Expand Down
3 changes: 2 additions & 1 deletion test/functional/page_objects/visual_builder_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -824,7 +824,8 @@ export class VisualBuilderPageObject extends FtrService {

public async setMetricsGroupBy(option: string) {
const groupBy = await this.testSubjects.find('groupBySelect');
await this.comboBox.setElement(groupBy, option, { clickWithMouse: true });
await this.comboBox.setElement(groupBy, option);
return await this.header.waitUntilLoadingHasFinished();
}

public async setMetricsGroupByTerms(
Expand Down

0 comments on commit ba67a66

Please sign in to comment.