Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Add the @custom pipeline only to the main datastream ingest pipeline #144150

Merged
merged 3 commits into from
Oct 31, 2022
Merged

[Fleet] Add the @custom pipeline only to the main datastream ingest pipeline #144150

merged 3 commits into from
Oct 31, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Oct 27, 2022 •
edited
Loading

Description

Resolve elastic/integrations#4510

Some integration use multiple pipeline for a datastream and then conditionaly apply them in a main pipeline, we are currently injecting the @custom pipeline in all the pipeline causing the @custom pipeline to be called multiple times

That PR fix that by adding the @custom pipeline only to the main pipeline and not to the sub ones.

Test

  • This is covered by a unit test

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet self-assigned this Oct 28, 2022
@nchaulet nchaulet added bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team v8.6.0 labels Oct 28, 2022
@nchaulet nchaulet marked this pull request as ready for review October 28, 2022 18:06
@nchaulet nchaulet requested a review from a team as a code owner October 28, 2022 18:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label Oct 28, 2022
@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

kpollich
kpollich approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nchaulet nchaulet enabled auto-merge (squash) October 31, 2022 13:02
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 57 63 +6
osquery 103 108 +5
securitySolution 439 443 +4
total +17

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 65 71 +6
osquery 104 110 +6
securitySolution 516 520 +4
total +18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 499e800 into elastic:main Oct 31, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 31, 2022
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 31, 2022
@jloleysens
Merge branch 'main' into files-make-files-namespace-agnostic
5aa9510 
* main:
  [Fleet] Add the @Custom pipeline only to the main datastream ingest pipelines (elastic#144150)
  Upgrade @elastic/makelogs from v6.0.0 to v6.1.1 (elastic#144231)
  [Files] move to src (elastic#144044)
  [Synthetics UI] Add pagination and date filtering to test runs table (elastic#144029)
@nchaulet nchaulet deleted the fix-custom-pipeline-only-main-pipelines branch November 23, 2022 21:00
@zmoog zmoog mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@Custom Pipeline Behaviour
5 participants
@nchaulet @elasticmachine @kibana-ci @kpollich @kibanamachine