Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Custom Pipeline Behaviour #4510

Closed
WildDogOne opened this issue Oct 27, 2022 · 3 comments · Fixed by elastic/kibana#144150
Closed

@Custom Pipeline Behaviour #4510

WildDogOne opened this issue Oct 27, 2022 · 3 comments · Fixed by elastic/kibana#144150
Labels
bug Something isn't working, use only for issues Team:Fleet Label for the Fleet team [elastic/fleet]

Comments

@WildDogOne
Copy link
Contributor

Hello Everyone,

Since (I think) V8.4 every integration pipeline automatically gets an appended @Custom pipeline
This of course makes a lot of sense, up till the point where we have an integration with chained Pipelines

Example Apache:
Pipeline "logs-apache.access-x.x.x" triggers "logs-apache.access-x.x.x-third-party"
and both of them trigger "logs-apache.access@custom"

This is redundant, and in worst case could bring about strange behaviour and errors.
I have no idea if this issue has been reported yet, and I don't even know if the integrations section is the right place...

Regards,

linus

@andrewkroh
Copy link
Member

andrewkroh commented Oct 27, 2022

@nchaulet Could you take a look at this. It looks like a bug. It sounds like the @custom is being injected into all pipelines instead of just the default/main pipeline for the data stream. Several integrations organize their logic using "sub-pipelines" where the main pipeline calls into a another pipeline based on some branching condition. We would only want the @custom to be injected into the a main pipeline.

Relates: elastic/kibana#134578

@andrewkroh andrewkroh added bug Something isn't working, use only for issues Team:Fleet Label for the Fleet team [elastic/fleet] labels Oct 27, 2022
@elasticmachine
Copy link

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Member

@nchaulet Could you take a look at this. It looks like a bug. It sounds like the @Custom is being injected into all pipelines instead of just the default/main pipeline for the data stream. Several integrations organize their logic using "sub-pipelines" where the main pipeline calls into a another pipeline based on some branching condition. We would only want the @Custom to be injected into the a main pipeline.

Yes you are correct looking at the code we inject the @custom pipeline for all the pipelines and not only the main one, it seems an easy one to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Team:Fleet Label for the Fleet team [elastic/fleet]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants