Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add a pipeline processor to all the ingest_pipeline installed by fleet #134578

Merged

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Jun 16, 2022

Description

Related to #133740

To allow users to write custom ingest pipeline, we add a new processor at the end at the end of the fleet install ingest_pipeline that will call the user custom ingest pipeline if it exists.

Release notes

That PR will enable user to write custom ingest pipeline for Fleet installed datastream.

Tests and how to manually test?

This features is tested with some unit tests and a new API integration test that index data with and without custom pipeline

If you want to manually test it you can use the custom log integration

1. check that the pipeline processor is correctly added to the datastream ingest pipeline

Screen Shot 2022-06-16 at 12 06 36 PM

2. create a custom pipeline logs-log.log@custom (could be done in the ingest pipeline UI)

Screen Shot 2022-06-16 at 12 16 42 PM

3. send data to the datastream and the custom ingest pipeline is called

Screen Shot 2022-06-16 at 12 17 31 PM

Screen Shot 2022-06-16 at 12 17 34 PM

@nchaulet nchaulet added release_note:enhancement auto-backport Deprecated - use backport:version if exact versions are needed v8.4.0 labels Jun 16, 2022
@nchaulet nchaulet self-assigned this Jun 16, 2022
@nchaulet nchaulet added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 16, 2022
@nchaulet nchaulet marked this pull request as ready for review June 16, 2022 16:18
@nchaulet nchaulet requested a review from a team as a code owner June 16, 2022 16:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kpollich kpollich self-requested a review June 16, 2022 16:22
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran through the whole process locally and everything works as expected. The code is sensible and has tests so no complaints there. One very minor nitpick on a method name but otherwise LGTM! Good luck with all the test failures 😅

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 75f786b into elastic:main Jun 16, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 16, 2022
@nchaulet nchaulet deleted the feature-add-custom-ingest-pipeliene-processor branch June 16, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting release_note:enhancement Team:Fleet Team label for Observability Data Collection Fleet team v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants