Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove geohash_grid aggregation #142977

Closed
wants to merge 1 commit into from
Closed

Conversation

ppisljar
Copy link
Member

Summary

removes geohash_grid aggregation
resolves #123192

@ppisljar ppisljar requested a review from a team as a code owner October 10, 2022 11:53
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 10, 2022

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / Aggs service setup() instantiates a new registry
  • [job] [logs] Jest Tests #1 / AggsService - public setup() registers custom agg types
  • [job] [logs] Jest Tests #1 / AggsService - public setup() registers default agg types
  • [job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution / Detection rules, bulk edit Prerequisites "before each" hook for "Prebuilt and custom rules selected: user proceeds with custom rules editing"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 520 518 -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2513 2503 -10

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
data 33 36 +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 437.1KB 433.4KB -3.6KB
Unknown metric groups

API count

id before after diff
data 3221 3211 -10

ESLint disabled in files

id before after diff
apm 14 13 -1
observability 8 7 -1
total -2

ESLint disabled line counts

id before after diff
apm 81 79 -2
enterpriseSearch 22 20 -2
observability 45 44 -1
securitySolution 411 407 -4
synthetics 60 54 -6
threatIntelligence 11 8 -3
ux 10 9 -1
total -19

Total ESLint disabled count

id before after diff
apm 95 92 -3
enterpriseSearch 23 21 -2
observability 53 51 -2
securitySolution 484 480 -4
synthetics 66 60 -6
threatIntelligence 12 9 -3
ux 13 12 -1
total -21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar ppisljar closed this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove geohash_grid aggregation support from kibana
2 participants