Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove geohash_grid aggregation support from kibana #123192

Closed
thomasneirynck opened this issue Jan 18, 2022 · 5 comments · Fixed by #152952
Closed

Remove geohash_grid aggregation support from kibana #123192

thomasneirynck opened this issue Jan 18, 2022 · 5 comments · Fixed by #152952
Labels
chore Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@thomasneirynck
Copy link
Contributor

The geohash_grid function was only used in the coordinate map-visualization. Since that visualization is removed in 8.0, we can remove those dead code paths from Kibana.

In addition to that, the geotile_grid function is a much better alternative for mapping purposes. This is the one that is used in Kibana Maps as well.
@thomasneirynck thomasneirynck added Team:AppServicesSv [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@thomasneirynck thomasneirynck changed the title Remove geohash_grid function from kibana Remove geohash_grid aggregation support from kibana Jan 18, 2022
@Dosant Dosant added the Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) label Jan 31, 2022
@Dosant Dosant mentioned this issue Jan 31, 2022
Closed
7 tasks
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort labels Jan 31, 2022
@exalate-issue-sync exalate-issue-sync bot added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Aug 29, 2022
@ppisljar ppisljar mentioned this issue Oct 10, 2022
Closed
@jb1b84 jb1b84 added Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Nov 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@petrklapka petrklapka added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:AppServicesSv labels Nov 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@nreese nreese mentioned this issue Mar 8, 2023
Merged
@nreese nreese added the technical debt Improvement of the software architecture and operational architecture label Mar 8, 2023
kibanamachine added a commit to Zacqary/kibana that referenced this issue Mar 20, 2023
@nreese @kibanamachine
remove geohash_grid aggregation support (elastic#152952)
098456a 
Fixes elastic#123192

geohash aggregation was only used by tile map visualization. Tile map
visualization was removed in 8.0, so geohash aggregation support no
longer needed.

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
6 participants
@nreese @thomasneirynck @Dosant @jb1b84 @elasticmachine @petrklapka