Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capping ack count not to exceed total actioned count #142848

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Oct 6, 2022

Summary

Fix #142846

Added a cap of action ack count not to exceed total actioned count, because the es query is not precise.

See explanation:
#142846 (comment)

@juliaElastic juliaElastic self-assigned this Oct 6, 2022
@juliaElastic juliaElastic requested a review from a team as a code owner October 6, 2022 13:08
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic juliaElastic added release_note:skip Skip the PR/issue when compiling release notes v8.6.0 labels Oct 6, 2022
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@juliaElastic juliaElastic enabled auto-merge (squash) October 6, 2022 13:25
@juliaElastic
Copy link
Contributor Author

@elasticmachine merge upstream

@juliaElastic
Copy link
Contributor Author

@elasticmachine merge upstream

@juliaElastic juliaElastic merged commit 8ce91ac into elastic:main Oct 6, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #33 / machine learning - data frame analytics classification saved search creation with filter and lucene query edits the analytics job and displays it correctly in the job list

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 6, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 6, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

actionId nbAgentsAck greater than nbAgentsActionCreated on completion
5 participants