capping ack count not to exceed total actioned count (elastic#142848)

WafaaNasr · Oct 11, 2022 · 8fceeee · 8fceeee
1 parent d74b716
commit 8fceeee
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/x-pack/plugins/fleet/server/services/agents/action_status.ts b/x-pack/plugins/fleet/server/services/agents/action_status.ts
@@ -64,12 +64,13 @@ export async function getActionStatuses(
     const matchingBucket = (acks?.aggregations?.ack_counts as any)?.buckets?.find(
       (bucket: any) => bucket.key === action.actionId
     );
+    const nbAgentsActioned = action.nbAgentsActioned || action.nbAgentsActionCreated;
     const nbAgentsAck = Math.min(
       matchingBucket?.doc_count ?? 0,
-      (matchingBucket?.agent_count as any)?.value ?? 0
+      (matchingBucket?.agent_count as any)?.value ?? 0,
+      nbAgentsActioned
     );
     const completionTime = (matchingBucket?.max_timestamp as any)?.value_as_string;
-    const nbAgentsActioned = action.nbAgentsActioned || action.nbAgentsActionCreated;
     const complete = nbAgentsAck >= nbAgentsActioned;
     const cancelledAction = cancelledActions.find((a) => a.actionId === action.actionId);