Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps] Change codeowners for stack_connectors #142843

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Oct 6, 2022

Summary

In PR #139867 we added CODEOWNERS for the stack_connectors plugin. Unfortunately, GitHub does not support having multiple code owners where at least one approval is enough to merge a PR. Both of them need to approve to be able to merge a PR. For that reason, this PR sets the CODEOWNERS for the stack_connectors plugin to the response-ops team so each team member can approve a PR that touches the stack_connectors plugin. This will help us to review faster and not block PRs.

For maintainers

@cnasikas cnasikas added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0 labels Oct 6, 2022
@cnasikas cnasikas requested a review from ymao1 October 6, 2022 12:43
@cnasikas cnasikas self-assigned this Oct 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@cnasikas cnasikas requested a review from a team October 6, 2022 12:45
@cnasikas cnasikas force-pushed the fix_connectors_codeowners branch from 3a16352 to bfc7dab Compare October 6, 2022 12:52
@cnasikas cnasikas requested a review from a team as a code owner October 6, 2022 12:52
@cnasikas cnasikas force-pushed the fix_connectors_codeowners branch from bfc7dab to 9f6dff6 Compare October 6, 2022 12:54
@cnasikas cnasikas changed the title [Case] Change codeowners for stack_connectors [ResponseOps] Change codeowners for stack_connectors Oct 6, 2022
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cnasikas cnasikas removed the request for review from a team October 6, 2022 12:56
@cnasikas cnasikas enabled auto-merge (squash) October 6, 2022 12:56
@elastic elastic deleted a comment from kibana-ci Oct 6, 2022
@kibana-ci
Copy link
Collaborator

💔 Build Failed

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas
Copy link
Member Author

cnasikas commented Oct 6, 2022

@elasticmachine merge upstream

@cnasikas cnasikas merged commit b076e4b into elastic:main Oct 6, 2022
@cnasikas cnasikas deleted the fix_connectors_codeowners branch October 6, 2022 13:10
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants