-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Response Ops] [Connectors] Move connectors to own plugin #139867
Conversation
6967649
to
91d1524
Compare
91d1524
to
ad01385
Compare
@@ -8,10 +8,6 @@ | |||
export const serviceNowITSMTable = 'incident'; | |||
export const serviceNowSIRTable = 'sn_si_incident'; | |||
|
|||
export const ServiceNowITSMActionTypeId = '.servicenow'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were unused so I deleted them.
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I tested the Swimlane and Jira connectors. I reached out to @EricDavisX and sounds like the QA team should be able to test out the remaining connectors 👍
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Pinging @elastic/fleet (Team:Fleet) |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @ymao1 |
Towards #90931
Summary
Created
stack_connectors
plugin and moved the connectors fromactions/server/built_in_action_types
into this new plugin. This only addresses the server side code. All client side code is still intriggers_actions_ui/public/built_in_action_types
and can be moved in a followup PR.Notable changes:
actions/server/built_in_action_types/lib
into the top level lib folder inactions/server/lib
. Connector type specific functions were moved with the connector type.actionConfigurationUtilities
in the executor function, so I refactored so those utilities are passed into the executor by theaction_executor
.actions
plugin.stack
andcases
stack
types are.email
,.index
,.pagerduty
,.server-log
,.slack
,.teams
,.webhook
cases
types are.cases-webhook
,.jira
,.resilient
,.servicenow
,.servicenow-sir
,.servicenow-itom
,.swimlane
,.xmatters
Followup PRs for moving the client side code and splitting out functional tests
To Verify
Ensure you can create and execute all connector types.