Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Response Ops] [Connectors] Move connectors to own plugin #139867

Merged
merged 36 commits into from
Sep 15, 2022

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Aug 31, 2022

Towards #90931

Summary

Created stack_connectors plugin and moved the connectors from actions/server/built_in_action_types into this new plugin. This only addresses the server side code. All client side code is still in triggers_actions_ui/public/built_in_action_types and can be moved in a followup PR.

Notable changes:

  • Moved non connector type specific functions from actions/server/built_in_action_types/lib into the top level lib folder in actions/server/lib. Connector type specific functions were moved with the connector type.
  • Many connector type definitions were still currying actionConfigurationUtilities in the executor function, so I refactored so those utilities are passed into the executor by the action_executor.
  • Moved an email specific (internal) route out of the actions plugin.
  • Tried to use the updated terminology inside the new plugin.
  • Split connector types into stack and cases
    • stack types are .email, .index, .pagerduty, .server-log, .slack, .teams, .webhook
    • cases types are .cases-webhook, .jira, .resilient, .servicenow, .servicenow-sir, .servicenow-itom, .swimlane, .xmatters

Followup PRs for moving the client side code and splitting out functional tests

To Verify

Ensure you can create and execute all connector types.

@ymao1 ymao1 force-pushed the connector-types-plugin branch 4 times, most recently from 6967649 to 91d1524 Compare September 7, 2022 17:25
@ymao1 ymao1 force-pushed the connector-types-plugin branch from 91d1524 to ad01385 Compare September 7, 2022 17:27
@ymao1 ymao1 changed the title Initial commit of stack connectors plugin [Response Ops] [Connectors] Move connectors to own plugin Sep 8, 2022
@@ -8,10 +8,6 @@
export const serviceNowITSMTable = 'incident';
export const serviceNowSIRTable = 'sn_si_incident';

export const ServiceNowITSMActionTypeId = '.servicenow';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were unused so I deleted them.

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 13, 2022

@elasticmachine merge upstream

@EricDavisX EricDavisX added the ci:cloud-deploy Create or update a Cloud deployment label Sep 13, 2022
Copy link
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I tested the Swimlane and Jira connectors. I reached out to @EricDavisX and sounds like the QA team should be able to test out the remaining connectors 👍

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 14, 2022

@elasticmachine merge upstream

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 15, 2022

@elasticmachine merge upstream

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 15, 2022

@elasticmachine merge upstream

@ymao1 ymao1 removed the ci:cloud-deploy Create or update a Cloud deployment label Sep 15, 2022
@ymao1
Copy link
Contributor Author

ymao1 commented Sep 15, 2022

@elasticmachine merge upstream

@kibanamachine kibanamachine requested a review from a team as a code owner September 15, 2022 17:20
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@ymao1
Copy link
Contributor Author

ymao1 commented Sep 15, 2022

@elasticmachine merge upstream

@ymao1 ymao1 removed the request for review from a team September 15, 2022 18:18
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
actions 13 12 -1
triggersActionsUi 599 601 +2
total +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
actions 268 209 -59
stackConnectors - 2 +2
total -57

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.0MB 1.0MB +1.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
actions 16.7KB 15.4KB -1.3KB
triggersActionsUi 92.4KB 92.6KB +223.0B
total -1.1KB
Unknown metric groups

API count

id before after diff
actions 273 214 -59
stackConnectors - 2 +2
total -57

ESLint disabled in files

id before after diff
actions 6 2 -4
stackConnectors - 4 +4
total -0

ESLint disabled line counts

id before after diff
actions 26 22 -4
stackConnectors - 5 +5
total +1

Total ESLint disabled count

id before after diff
actions 32 24 -8
stackConnectors - 9 +9
total +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 merged commit 914d1cd into elastic:main Sep 15, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 15, 2022
@ymao1 ymao1 deleted the connector-types-plugin branch September 15, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants