[ResponseOps][Cases] Align case avatars #140227

jonathan-buttner · 2022-09-07T21:24:09Z

This PR refactors the case avatars to use the same style designed for the case assignments feature. This PR does not adjust the reporters or participants section.

It also does not address that the backend is not storing the profile uid when a user is stored. This will be addressed is a separate PR.

This PR is stacked on top of the feature branch PR here: #140208

Example

uniform.avatars.mov

…38108) * Add reusable user profile selector component * Refactoring services, auth * Adding suggest api and tests * Move to package and add examples * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Working integration tests * Switching suggest api tags * Adding assignees field * Adding tests for size and owner * Add server side example * CI Fixes * Adding assignee integration tests * fix tests * Addd tests * Starting user actions changes * Adding api tag tests * Addressing feedback * Using lodash for array comparison logic and tests * Fixing type error * Create suggest query * Adding assignees user action * [ResponseOps][Cases] Refactoring client args and authentication (elastic#137345) * Refactoring services, auth * Fixing type errors * Adding assignees migration and tests * Fixing types and added more tests * Fixing cypress test * Fixing test * Add tests * Add security as dependency and fix types * Add bulk get profiles query * Rename folder * Addressed suggestions from code review * Fix types * Adding migration for assignees field and tests * Adding comments and a few more tests * Updating comments and spelling * Revert security solution optional * PR feedback * Updated user avatar component * Reduce size * Make security required * Fix tests * Addressing feedback * Do not retry suggestions * Assign users to a case * Restructure components * Move assignees to case view * Show assigned users * Refactoring bulk get and display name * Adding tests for user tooltip * Adding tests * Hovering and tests * Fixing errors * Some pr clean up * Fixing tests and adding more * Adding functional tests * Fixing jest test failure * Passing in current user profile * Refactoring assignment with useEffect * Fixing icon alignment and removal render bug * Fixing type errors * Fixing test errors * Adding bulk get privs and tests * Fixing popover tests * Handling unknown users * Adding tests for unknown users * Adding wait for popover calls * Addressing design feedback * Addressing remaining feedback * Refactoring css and name prop * Refactoring popover * Refactoring search component * Addressing some feedback * Adjusting sorting * Fixing tests * Fixing type error * Fixing test error * Fixing test errors * Removing display name Co-authored-by: Thom Heymann <[email protected]> Co-authored-by: Jonathan Buttner <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Thom Heymann <[email protected]> Co-authored-by: Jonathan Buttner <[email protected]>

…gnment

* Adding user actions for assignees * Fixing merge issues * Fixing test mock errors * Fixing display name errors and themselves * Fixing test for time being * Addressing feedback * Addressing comma and uniq feedback * Using core getUserDisplayName * Fixing import and removing flickering * Fixing tests Co-authored-by: Kibana Machine <[email protected]>

…gnment

…o cases-user-assignment

…gnment

* Init * Render users * Assign yourself * Add tests * Fix tests * PR feedback

* Starting the filtering * Rough draft working for assignees filtering * Adding integration tests for new route * Starting to write tests * Fixing tests * Cleaning up more tests * Removing duplicate call for current user * Fixing type errors and tests * Adding tests for filtering * Adding rbac tests * Fixing translations * Fixing api integration tests * Fixing severity tests * Really fixing arrays equal * Fixing ml tests and refactoring find assignees * Fixing cypress tests * Fixing types * Fix tests * Addressing first round of feedback * Reverting the recent cases changes * Fixing tests * Fixing more tests and types * Allowing multi select * Fixing attachment framework issue * Addressing feedback

…gnment

elasticmachine · 2022-09-12T16:36:10Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2022-09-12T16:36:11Z

Pinging @elastic/response-ops-cases (Feature:Cases)

michaelolo24

Security solution changes!

cnasikas · 2022-09-13T07:35:41Z

x-pack/plugins/cases/common/ui/types.ts

@@ -126,6 +126,7 @@ export interface ElasticUser {
  readonly email?: string | null;
  readonly fullName?: string | null;
  readonly username?: string | null;
+  readonly profileUid?: string | null;


nit: Is it possible to use SnakeToCamelCase<User> to define the ElasticUser interface?

cnasikas · 2022-09-13T07:39:12Z

x-pack/plugins/cases/public/components/case_view/components/user_list.tsx

-          aria-label={i18n.SEND_EMAIL_ARIA(fullName ? fullName : username ?? '')}
-          isDisabled={isEmpty(email)}
+          aria-label={i18n.SEND_EMAIL_ARIA(
+            userInfo.user?.full_name ? userInfo.user?.full_name : userInfo.user?.username ?? ''


If I remember correctly we have a utility function to return us a valid name, correct?

There's one slight difference, the utility function will do full_name -> email -> username -> unknown. This logic does full_name -> username -> ''. Using the utility function should be fine though right?

cnasikas · 2022-09-13T07:45:28Z

x-pack/plugins/cases/public/components/user_actions/index.test.tsx

-        );
-      });
+      appMockRender.render(<UserActions {...props} />);
+      // there are two because one is for the


nit: for the? 🙂

No idea what I was going for here haha, will remove.

cnasikas

Code LGTM! Tested locally without any issues

kibana-ci · 2022-09-13T20:29:15Z

💚 Build Succeeded

Buildkite Build
Commit: 6bff9db

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`cases`	484	489	+5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	367.5KB	368.8KB	+1.4KB

History

💔 Build #71901 failed 2cdae09
💚 Build #71351 succeeded 18727db
💔 Build #71343 failed 707c2f1
💔 Build #71332 failed aac7448
💔 Build #71245 failed bdc74a1
💔 Build #70980 failed 3a6d267

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cnasikas and others added 15 commits August 24, 2022 11:26

Merge branch 'main' of github.com:elastic/kibana into cases-user-assi…

939f52b

…gnment

Merge branch 'main' of github.com:elastic/kibana into cases-user-assi…

15f2279

…gnment

Merge branch 'cases-user-assignment' of github.com:elastic/kibana int…

1c4942f

…o cases-user-assignment

Merge branch 'main' of github.com:elastic/kibana into cases-user-assi…

622fbdc

…gnment

Merge branch 'main' into cases-user-assignment

0657743

Detect when user is typing

301770e

Use select to tranform data

8103bd3

[Cases] Assign users when creating a case (elastic#139754)

01006bf

* Init * Render users * Assign yourself * Add tests * Fix tests * PR feedback

Merge branch 'main' of github.com:elastic/kibana into cases-user-assi…

41a44c6

…gnment

Fixing type error

da1b4a8

Fixing tests

80f847f

Refactoring components

d1237af

jonathan-buttner added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.5.0 labels Sep 7, 2022

jonathan-buttner added 6 commits September 8, 2022 15:15

Refactoring the users lists

f3135f5

Switching all user action avatars

3a6d267

Merge branch 'main' of github.com:elastic/kibana into cases-avatars

bdc74a1

Fixing merge issues

aac7448

Merge branch 'main' of github.com:elastic/kibana into cases-avatars

707c2f1

Fixing types

18727db

jonathan-buttner marked this pull request as ready for review September 12, 2022 16:36

jonathan-buttner requested review from a team as code owners September 12, 2022 16:36

jonathan-buttner requested review from cnasikas and peteharverson September 12, 2022 16:37

michaelolo24 approved these changes Sep 12, 2022

View reviewed changes

cnasikas reviewed Sep 13, 2022

View reviewed changes

cnasikas approved these changes Sep 13, 2022

View reviewed changes

jonathan-buttner added 3 commits September 13, 2022 13:28

Merge branch 'main' of github.com:elastic/kibana into cases-avatars

af88572

Addressing feedback

2cdae09

Fixing type errors

6bff9db

cnasikas mentioned this pull request Sep 14, 2022

[ResponseOps][Cases] Design feedback for cases #139039

Open

37 tasks

jonathan-buttner merged commit a58778f into elastic:main Sep 14, 2022

kibanamachine added the backport:skip This commit does not require backporting label Sep 14, 2022

jonathan-buttner deleted the cases-avatars branch September 14, 2022 11:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ResponseOps][Cases] Align case avatars #140227

[ResponseOps][Cases] Align case avatars #140227

jonathan-buttner commented Sep 7, 2022 •

edited

Loading

elasticmachine commented Sep 12, 2022

elasticmachine commented Sep 12, 2022

michaelolo24 left a comment

cnasikas Sep 13, 2022

cnasikas Sep 13, 2022

jonathan-buttner Sep 13, 2022

cnasikas Sep 13, 2022

jonathan-buttner Sep 13, 2022

cnasikas left a comment

kibana-ci commented Sep 13, 2022

[ResponseOps][Cases] Align case avatars #140227

[ResponseOps][Cases] Align case avatars #140227

Conversation

jonathan-buttner commented Sep 7, 2022 • edited Loading

elasticmachine commented Sep 12, 2022

elasticmachine commented Sep 12, 2022

michaelolo24 left a comment

Choose a reason for hiding this comment

cnasikas Sep 13, 2022

Choose a reason for hiding this comment

cnasikas Sep 13, 2022

Choose a reason for hiding this comment

jonathan-buttner Sep 13, 2022

Choose a reason for hiding this comment

cnasikas Sep 13, 2022

Choose a reason for hiding this comment

jonathan-buttner Sep 13, 2022

Choose a reason for hiding this comment

cnasikas left a comment

Choose a reason for hiding this comment

kibana-ci commented Sep 13, 2022

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

jonathan-buttner commented Sep 7, 2022 •

edited

Loading