[Cases] Assign users when creating a case #139754

cnasikas · 2022-08-30T17:47:33Z

Summary

This PR implements the assignment of users when creating a case. It does not implement suggestions. It will be addressed in another PR.

Assignment of users

create_case_assign_users.mp4

Self assignment

create_case_assign_self.mp4

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2022-09-01T08:49:40Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2022-09-01T08:49:41Z

Pinging @elastic/response-ops-cases (Feature:Cases)

peteharverson

Tested locally and LGTM

jonathan-buttner · 2022-09-01T14:13:19Z

x-pack/plugins/cases/public/common/translations.ts

@@ -296,3 +296,7 @@ export const READ_ACTIONS_PERMISSIONS_ERROR_MSG = i18n.translate(
      'You do not have permission to view connectors. If you would like to view connectors, contact your Kibana administrator.',
  }
 );
+
+export const ASSIGNEES = i18n.translate('xpack.cases.common.assigneesTitle', {


I've moved this to the user_profiles/translations should we keep it in common like you have it instead?

I put it in the common because multiple components use it. I am fine with both. It is up to you :).

jonathan-buttner · 2022-09-01T14:15:22Z

x-pack/plugins/cases/public/components/create/assignees.tsx

+      {(field) => {
+        const { setValue } = field;
+
+        const onComboChange = (currentOptions: EuiComboBoxOptionOption[]) => {


Should onComboChange and onSelfAssign be useCallbacks?

Correct, I forgot about it. Thanks!

I get this linting error because the functions are inside another function:

Seems like we might be able to get around that by using the component prop of UseField:

x-pack/plugins/index_management/public/application/components/mappings_editor/components/document_fields/field_parameters/other_type_name_parameter.tsx

Maybe that's overkill though 🤷‍♂️

Nice, I wasn't aware of that. I will take a look.

jonathan-buttner · 2022-09-01T14:21:36Z

x-pack/plugins/cases/public/components/create/assignees.tsx

+              selectedOptions={selectedOptions}
+              isDisabled={isLoading}
+              onChange={onComboChange}
+              onSearchChange={onSearchComboChange}


Could we pass setSearchTerm here directly? useSuggestUserProfiles currently checks for an empty string and returns null but depending on the outcome of the suggestions discussion we'll likely want to return whatever the hook returns even if we search with an empty string.

If you search and click on a user suggestion then the onSearchChange is called with an empty string. This will call the backend and return null making the suggestion list disappear. For that reason, we need to check if the search term is an empty string and prevent the call to the backend.

1.mp4

kibana-ci · 2022-09-06T12:28:02Z

💔 Build Failed

Failed CI Steps

Test Failures

[job] [logs] FTR Configs #25 / Cases Attachment framework Attachment hooks Flyout attaches correctly
[job] [logs] FTR Configs #25 / Cases Attachment framework Attachment hooks Flyout attaches correctly
[job] [logs] Jest Tests #6 / EditableTitle renders
[job] [logs] Jest Tests #6 / EditConnector displays the callout message when none is selected
[job] [logs] Jest Tests #6 / HeaderPage it renders
[job] [logs] FTR Configs #7 / machine learning - anomaly detection anomaly explorer with farequote based multi metric job Anomaly Swim Lane as embeddable attaches swim lane embeddable to a case
[job] [logs] FTR Configs #7 / machine learning - anomaly detection anomaly explorer with farequote based multi metric job Anomaly Swim Lane as embeddable attaches swim lane embeddable to a case

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [8103bd3]

History

💔 Build #69272 failed a3413e3
💔 Build #69266 failed 522d26c
💔 Build #68786 failed c7aa27e
💔 Build #68732 failed ca96552

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

* [ResponseOps][Cases] Assign users on cases sidebar section (#138108) * Add reusable user profile selector component * Refactoring services, auth * Adding suggest api and tests * Move to package and add examples * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Working integration tests * Switching suggest api tags * Adding assignees field * Adding tests for size and owner * Add server side example * CI Fixes * Adding assignee integration tests * fix tests * Addd tests * Starting user actions changes * Adding api tag tests * Addressing feedback * Using lodash for array comparison logic and tests * Fixing type error * Create suggest query * Adding assignees user action * [ResponseOps][Cases] Refactoring client args and authentication (#137345) * Refactoring services, auth * Fixing type errors * Adding assignees migration and tests * Fixing types and added more tests * Fixing cypress test * Fixing test * Add tests * Add security as dependency and fix types * Add bulk get profiles query * Rename folder * Addressed suggestions from code review * Fix types * Adding migration for assignees field and tests * Adding comments and a few more tests * Updating comments and spelling * Revert security solution optional * PR feedback * Updated user avatar component * Reduce size * Make security required * Fix tests * Addressing feedback * Do not retry suggestions * Assign users to a case * Restructure components * Move assignees to case view * Show assigned users * Refactoring bulk get and display name * Adding tests for user tooltip * Adding tests * Hovering and tests * Fixing errors * Some pr clean up * Fixing tests and adding more * Adding functional tests * Fixing jest test failure * Passing in current user profile * Refactoring assignment with useEffect * Fixing icon alignment and removal render bug * Fixing type errors * Fixing test errors * Adding bulk get privs and tests * Fixing popover tests * Handling unknown users * Adding tests for unknown users * Adding wait for popover calls * Addressing design feedback * Addressing remaining feedback * Refactoring css and name prop * Refactoring popover * Refactoring search component * Addressing some feedback * Adjusting sorting * Fixing tests * Fixing type error * Fixing test error * Fixing test errors * Removing display name Co-authored-by: Thom Heymann <[email protected]> Co-authored-by: Jonathan Buttner <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Thom Heymann <[email protected]> Co-authored-by: Jonathan Buttner <[email protected]> * [ResponseOps][Cases] Add assignee user actions (#139392) * Adding user actions for assignees * Fixing merge issues * Fixing test mock errors * Fixing display name errors and themselves * Fixing test for time being * Addressing feedback * Addressing comma and uniq feedback * Using core getUserDisplayName * Fixing import and removing flickering * Fixing tests Co-authored-by: Kibana Machine <[email protected]> * Detect when user is typing * Use select to tranform data * [Cases] Assign users when creating a case (#139754) * Init * Render users * Assign yourself * Add tests * Fix tests * PR feedback * [ResponseOps][Cases] Filter by assignees (#139441) * Starting the filtering * Rough draft working for assignees filtering * Adding integration tests for new route * Starting to write tests * Fixing tests * Cleaning up more tests * Removing duplicate call for current user * Fixing type errors and tests * Adding tests for filtering * Adding rbac tests * Fixing translations * Fixing api integration tests * Fixing severity tests * Really fixing arrays equal * Fixing ml tests and refactoring find assignees * Fixing cypress tests * Fixing types * Fix tests * Addressing first round of feedback * Reverting the recent cases changes * Fixing tests * Fixing more tests and types * Allowing multi select * Fixing attachment framework issue * Addressing feedback * Fixing type error * Fixing tests * Sort users and improve loading * Fix ml security dependecies * Fix permissions when fetching suggestions * Fixing read permissions and suggest api * Hiding assignee delete icon * Hiding the assign yourself text when undefined * Create page fixes Co-authored-by: Christos Nasikas <[email protected]> Co-authored-by: Thom Heymann <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Thom Heymann <[email protected]>

* [ResponseOps][Cases] Assign users on cases sidebar section (#138108) * Add reusable user profile selector component * Refactoring services, auth * Adding suggest api and tests * Move to package and add examples * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Working integration tests * Switching suggest api tags * Adding assignees field * Adding tests for size and owner * Add server side example * CI Fixes * Adding assignee integration tests * fix tests * Addd tests * Starting user actions changes * Adding api tag tests * Addressing feedback * Using lodash for array comparison logic and tests * Fixing type error * Create suggest query * Adding assignees user action * [ResponseOps][Cases] Refactoring client args and authentication (#137345) * Refactoring services, auth * Fixing type errors * Adding assignees migration and tests * Fixing types and added more tests * Fixing cypress test * Fixing test * Add tests * Add security as dependency and fix types * Add bulk get profiles query * Rename folder * Addressed suggestions from code review * Fix types * Adding migration for assignees field and tests * Adding comments and a few more tests * Updating comments and spelling * Revert security solution optional * PR feedback * Updated user avatar component * Reduce size * Make security required * Fix tests * Addressing feedback * Do not retry suggestions * Assign users to a case * Restructure components * Move assignees to case view * Show assigned users * Refactoring bulk get and display name * Adding tests for user tooltip * Adding tests * Hovering and tests * Fixing errors * Some pr clean up * Fixing tests and adding more * Adding functional tests * Fixing jest test failure * Passing in current user profile * Refactoring assignment with useEffect * Fixing icon alignment and removal render bug * Fixing type errors * Fixing test errors * Adding bulk get privs and tests * Fixing popover tests * Handling unknown users * Adding tests for unknown users * Adding wait for popover calls * Addressing design feedback * Addressing remaining feedback * Refactoring css and name prop * Refactoring popover * Refactoring search component * Addressing some feedback * Adjusting sorting * Fixing tests * Fixing type error * Fixing test error * Fixing test errors * Removing display name Co-authored-by: Thom Heymann <[email protected]> Co-authored-by: Jonathan Buttner <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Thom Heymann <[email protected]> Co-authored-by: Jonathan Buttner <[email protected]> * [ResponseOps][Cases] Add assignee user actions (#139392) * Adding user actions for assignees * Fixing merge issues * Fixing test mock errors * Fixing display name errors and themselves * Fixing test for time being * Addressing feedback * Addressing comma and uniq feedback * Using core getUserDisplayName * Fixing import and removing flickering * Fixing tests Co-authored-by: Kibana Machine <[email protected]> * Detect when user is typing * Use select to tranform data * [Cases] Assign users when creating a case (#139754) * Init * Render users * Assign yourself * Add tests * Fix tests * PR feedback * [ResponseOps][Cases] Filter by assignees (#139441) * Starting the filtering * Rough draft working for assignees filtering * Adding integration tests for new route * Starting to write tests * Fixing tests * Cleaning up more tests * Removing duplicate call for current user * Fixing type errors and tests * Adding tests for filtering * Adding rbac tests * Fixing translations * Fixing api integration tests * Fixing severity tests * Really fixing arrays equal * Fixing ml tests and refactoring find assignees * Fixing cypress tests * Fixing types * Fix tests * Addressing first round of feedback * Reverting the recent cases changes * Fixing tests * Fixing more tests and types * Allowing multi select * Fixing attachment framework issue * Addressing feedback * Fixing type error * Fixing tests * Refactoring components * Refactoring the users lists * Switching all user action avatars * Fixing merge issues * Fixing types * Addressing feedback * Fixing type errors Co-authored-by: Christos Nasikas <[email protected]> Co-authored-by: Thom Heymann <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Thom Heymann <[email protected]>

* [ResponseOps][Cases] Assign users on cases sidebar section (#138108) * Add reusable user profile selector component * Refactoring services, auth * Adding suggest api and tests * Move to package and add examples * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Working integration tests * Switching suggest api tags * Adding assignees field * Adding tests for size and owner * Add server side example * CI Fixes * Adding assignee integration tests * fix tests * Addd tests * Starting user actions changes * Adding api tag tests * Addressing feedback * Using lodash for array comparison logic and tests * Fixing type error * Create suggest query * Adding assignees user action * [ResponseOps][Cases] Refactoring client args and authentication (#137345) * Refactoring services, auth * Fixing type errors * Adding assignees migration and tests * Fixing types and added more tests * Fixing cypress test * Fixing test * Add tests * Add security as dependency and fix types * Add bulk get profiles query * Rename folder * Addressed suggestions from code review * Fix types * Adding migration for assignees field and tests * Adding comments and a few more tests * Updating comments and spelling * Revert security solution optional * PR feedback * Updated user avatar component * Reduce size * Make security required * Fix tests * Addressing feedback * Do not retry suggestions * Assign users to a case * Restructure components * Move assignees to case view * Show assigned users * Refactoring bulk get and display name * Adding tests for user tooltip * Adding tests * Hovering and tests * Fixing errors * Some pr clean up * Fixing tests and adding more * Adding functional tests * Fixing jest test failure * Passing in current user profile * Refactoring assignment with useEffect * Fixing icon alignment and removal render bug * Fixing type errors * Fixing test errors * Adding bulk get privs and tests * Fixing popover tests * Handling unknown users * Adding tests for unknown users * Adding wait for popover calls * Addressing design feedback * Addressing remaining feedback * Refactoring css and name prop * Refactoring popover * Refactoring search component * Addressing some feedback * Adjusting sorting * Fixing tests * Fixing type error * Fixing test error * Fixing test errors * Removing display name Co-authored-by: Thom Heymann <[email protected]> Co-authored-by: Jonathan Buttner <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Thom Heymann <[email protected]> Co-authored-by: Jonathan Buttner <[email protected]> * [ResponseOps][Cases] Add assignee user actions (#139392) * Adding user actions for assignees * Fixing merge issues * Fixing test mock errors * Fixing display name errors and themselves * Fixing test for time being * Addressing feedback * Addressing comma and uniq feedback * Using core getUserDisplayName * Fixing import and removing flickering * Fixing tests Co-authored-by: Kibana Machine <[email protected]> * Detect when user is typing * Use select to tranform data * [Cases] Assign users when creating a case (#139754) * Init * Render users * Assign yourself * Add tests * Fix tests * PR feedback * [ResponseOps][Cases] Filter by assignees (#139441) * Starting the filtering * Rough draft working for assignees filtering * Adding integration tests for new route * Starting to write tests * Fixing tests * Cleaning up more tests * Removing duplicate call for current user * Fixing type errors and tests * Adding tests for filtering * Adding rbac tests * Fixing translations * Fixing api integration tests * Fixing severity tests * Really fixing arrays equal * Fixing ml tests and refactoring find assignees * Fixing cypress tests * Fixing types * Fix tests * Addressing first round of feedback * Reverting the recent cases changes * Fixing tests * Fixing more tests and types * Allowing multi select * Fixing attachment framework issue * Addressing feedback * Fixing type error * Fixing tests * Sort users and improve loading * Fix ml security dependecies * Fix permissions when fetching suggestions * Fixing read permissions and suggest api * Hiding assignee delete icon * Hiding the assign yourself text when undefined * Show licensing callout to the all cases page * Hide assignees column * Hide assignees & connectors column * Renames * Check licensing when assigning users to a case * Hide assinee from create case page * Hide assignee filtering * Check license when filtering by assignees * Add UI tests & fixes * Add integration tests * Fix tests * Fix i18n * Revert core changes * PR feedback and fix tests * PR feedback Co-authored-by: Thom Heymann <[email protected]> Co-authored-by: Jonathan Buttner <[email protected]> Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Thom Heymann <[email protected]> Co-authored-by: Jonathan Buttner <[email protected]>

cnasikas added 2 commits August 30, 2022 19:29

Init

455e726

Render users

2f00f85

cnasikas added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.5.0 labels Aug 30, 2022

cnasikas assigned cnasikas and unassigned cnasikas Aug 30, 2022

cnasikas added 3 commits August 31, 2022 16:23

Assign yourself

bc411de

Merge branch 'cases-user-assignment' into create_case_assign_user

ca96552

Add tests

c7aa27e

cnasikas force-pushed the create_case_assign_user branch from 8fc555f to c7aa27e Compare August 31, 2022 17:05

cnasikas marked this pull request as ready for review September 1, 2022 08:49

cnasikas requested a review from a team as a code owner September 1, 2022 08:49

peteharverson approved these changes Sep 1, 2022

View reviewed changes

jonathan-buttner reviewed Sep 1, 2022

View reviewed changes

cnasikas added 3 commits September 2, 2022 15:17

Fix tests

2f05299

Merge branch 'cases-user-assignment' into create_case_assign_user

522d26c

PR feedback

a3413e3

cnasikas requested a review from jonathan-buttner September 4, 2022 11:46

cnasikas mentioned this pull request Sep 6, 2022

[Cases] Assign users to a case #134160

Closed

7 tasks

Merge branch 'cases-user-assignment' into create_case_assign_user

2dd56cb

cnasikas merged commit 01006bf into elastic:cases-user-assignment Sep 6, 2022

cnasikas deleted the create_case_assign_user branch September 6, 2022 14:26

jonathan-buttner mentioned this pull request Sep 7, 2022

[ResponseOps][Cases] User assignment #140208

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cases] Assign users when creating a case #139754

[Cases] Assign users when creating a case #139754

cnasikas commented Aug 30, 2022 •

edited

Loading

elasticmachine commented Sep 1, 2022

elasticmachine commented Sep 1, 2022

peteharverson left a comment

jonathan-buttner Sep 1, 2022

cnasikas Sep 2, 2022

jonathan-buttner Sep 1, 2022

cnasikas Sep 2, 2022

cnasikas Sep 2, 2022

jonathan-buttner Sep 2, 2022

cnasikas Sep 2, 2022

cnasikas Sep 2, 2022

jonathan-buttner Sep 1, 2022

cnasikas Sep 2, 2022 •

edited

Loading

kibana-ci commented Sep 6, 2022 •

edited

Loading

[Cases] Assign users when creating a case #139754

[Cases] Assign users when creating a case #139754

Conversation

cnasikas commented Aug 30, 2022 • edited Loading

Summary

Assignment of users

Self assignment

Checklist

For maintainers

elasticmachine commented Sep 1, 2022

elasticmachine commented Sep 1, 2022

peteharverson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cnasikas Sep 2, 2022 • edited Loading

Choose a reason for hiding this comment

kibana-ci commented Sep 6, 2022 • edited Loading

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

History

cnasikas commented Aug 30, 2022 •

edited

Loading

cnasikas Sep 2, 2022 •

edited

Loading

kibana-ci commented Sep 6, 2022 •

edited

Loading