[Upgrade] Fixes cloud upgrade test failures for 8.x #138684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 4, 2022 11:04
liza-mae
added
release_note:skip
nreese
reviewed
Aug 11, 2022
jughosta
approved these changes
Aug 12, 2022
kobelb
approved these changes
Aug 12, 2022
jloleysens
approved these changes
Aug 12, 2022
nreese
reviewed
Aug 15, 2022
nreese
reviewed
Aug 15, 2022
| // Please keep in mind when udpating, removing or adding to this method | ||
| // upgrade needs to be tested too | ||
| async clearLegendTooltip() { | ||
| const isTooltipOpen = await this.testSubjects.exists(`layerTocTooltip`, { timeout: 5000 }); |
There was a problem hiding this comment.
One more thing, can this exists timeout be shorter? how about 1000 or 1500?
There was a problem hiding this comment.
What I noticed when testing against cloud is things in the UI are slower, take longer to show up, so if it is too short we may miss it and it will cause it to be flaky
nreese
approved these changes
Aug 16, 2022
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @liza-mae |
kibanamachine
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Update discover and canvas tests * Add length * Update rule name to have no spaces * Fix calling function * Try to close tooltip * Fix rules spinner * Move toggleLayerVisibility to gis_page * Add wait for layers to load * Remove unused declaration Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 9969513)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 18, 2022
…lastic#139101) * Update discover and canvas tests * Add length * Update rule name to have no spaces * Fix calling function * Try to close tooltip * Fix rules spinner * Move toggleLayerVisibility to gis_page * Add wait for layers to load * Remove unused declaration Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 9969513) Co-authored-by: liza-mae <[email protected]>
Mpdreamz
pushed a commit
to Mpdreamz/kibana
that referenced
this pull request
Sep 6, 2022
* Update discover and canvas tests * Add length * Update rule name to have no spaces * Fix calling function * Try to close tooltip * Fix rules spinner * Move toggleLayerVisibility to gis_page * Add wait for layers to load * Remove unused declaration Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes test failures on 8.4 and 8.5 branches.
We had around 90+ test failures here:
https://internal-ci.elastic.co/view/Stack%20Tests/job/elastic+estf-cloud-upgrade-snapshot-tests+main/103/
https://internal-ci.elastic.co/view/Stack%20Tests/job/elastic+estf-cloud-upgrade-snapshot-tests+8.4/8/testReport/
This PR has dropped the failures down to about 20: (Looks like some security solutions tests are also now failing) -- Only 4 are Kibana core failures, two are discover flaky test problem and still some issues with the rules search filter for the other two failures.
https://internal-ci.elastic.co/view/Stack%20Tests/job/elastic+estf-cloud-upgrade-snapshot-tests+main/114/testReport/