Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] fix flaky metric test #138585

Merged
merged 2 commits into from
Aug 12, 2022
Merged

[Lens] fix flaky metric test #138585

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2951f3
clear input before typing new color
drewdaemon Aug 11, 2022
c0b59be
wait for filter retries
drewdaemon Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions x-pack/test/functional/apps/lens/group3/metric.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
}
};

// Failing: See https://github.com/elastic/kibana/issues/138295
describe.skip('lens metric', () => {
describe('lens metric', () => {
it('should render a metric', async () => {
await PageObjects.visualize.navigateToNewVisualization();
await PageObjects.visualize.clickVisType('lens');
Expand Down Expand Up @@ -158,7 +157,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const title = '93.28.27.24';
await clickMetric(title);

retry.try(async () => {
await retry.try(async () => {
const labels = await filterBar.getFiltersLabel();
expect(labels.length).to.be(1);
expect(labels[0]).to.be(`ip: ${title}`);
Expand All @@ -174,6 +173,8 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
);

const colorPicker = await testSubjects.find('euiColorPickerAnchor');

colorPicker.clearValue();
await colorPicker.type('#000000');

await PageObjects.lens.waitForVisualization('mtrVis');
Expand Down