Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] fix flaky metric test #138585

Merged
merged 2 commits into from
Aug 12, 2022
Merged

[Lens] fix flaky metric test #138585

merged 2 commits into from
Aug 12, 2022

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Aug 11, 2022 •
edited by kibanamachine
Loading

Summary

Fix #138295

Flaky test runner build: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1024 (one failure from a different test: #138502)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon marked this pull request as ready for review August 12, 2022 13:02
@drewdaemon drewdaemon requested a review from a team as a code owner August 12, 2022 13:02
@drewdaemon drewdaemon added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes labels Aug 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@drewdaemon drewdaemon changed the title [Lens] clear input before typing new color [Lens] fix flaky metric test Aug 12, 2022
flash1293
flash1293 approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@drewdaemon drewdaemon merged commit 1b71ff9 into elastic:main Aug 12, 2022
@kibanamachine kibanamachine added v8.5.0 backport:skip This commit does not require backporting labels Aug 12, 2022
@drewdaemon drewdaemon added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Aug 12, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.4 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.4:
- Fix console tests on cloud (#138682)
- [Security Solution][Detections] fixes tests related to prebuilt rules update (#138625)
- batch 1 of removing es_archives/empty_kibana (#138189)
- [ML] Data Visualizer: Add functional tests for pinned filters (#138539)

Manual backport

To create the backport manually run:

node scripts/backport --pr 138585

Questions ?

Please refer to the Backport tool documentation

@drewdaemon drewdaemon removed the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Aug 15, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Aug 15, 2022
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this pull request Sep 6, 2022
@drewdaemon @Mpdreamz
[Lens] fix flaky metric test (elastic#138585)
afb0335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

@flash1293 flash1293 flash1293 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.5.0
Projects
None yet
Milestone
No milestone
6 participants
@drewdaemon @kibana-ci @elasticmachine @kibanamachine @flash1293 @mbondyra