Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Explain log rates spikes: Fix API messages translations. #137589

Merged
merged 4 commits into from
Aug 1, 2022
Merged

[ML] Explain log rates spikes: Fix API messages translations. #137589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01fa620
[ML] Explain log rates spikes: Fix API messages translations.
walterra Jul 29, 2022
bb99a53
[ML] Fix API integration tests.
walterra Jul 29, 2022
de8843d
Merge branch 'main' into ml-aiops-api-translations
walterra Aug 1, 2022
c7537bf
Merge branch 'main' into ml-aiops-api-translations
kibanamachine Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 46 additions & 14 deletions x-pack/plugins/aiops/server/routes/explain_log_rate_spikes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import { chunk } from 'lodash';

import { i18n } from '@kbn/i18n';
import { asyncForEach } from '@kbn/std';
import type { IRouter } from '@kbn/core/server';
import { KBN_FIELD_TYPES } from '@kbn/field-types';
Expand Down Expand Up @@ -81,7 +82,12 @@ export const defineExplainLogRateSpikesRoute = (
updateLoadingStateAction({
ccsWarning: false,
loaded,
loadingState: 'Loading field candidates.',
loadingState: i18n.translate(
'xpack.aiops.explainLogRateSpikes.loadingState.loadingFieldCandidates',
{
defaultMessage: 'Loading field candidates.',
}
),
})
);

Expand All @@ -104,7 +110,16 @@ export const defineExplainLogRateSpikesRoute = (
updateLoadingStateAction({
ccsWarning: false,
loaded,
loadingState: `Identified ${fieldCandidates.length} field candidates.`,
loadingState: i18n.translate(
'xpack.aiops.explainLogRateSpikes.loadingState.identifiedFieldCandidates',
{
defaultMessage:
'Identified {fieldCandidatesCount, plural, one {# field candidate} other {# field candidates}}.',
values: {
fieldCandidatesCount: fieldCandidates.length,
},
}
),
})
);

Expand Down Expand Up @@ -144,9 +159,16 @@ export const defineExplainLogRateSpikesRoute = (
updateLoadingStateAction({
ccsWarning: false,
loaded,
loadingState: `Identified ${
changePoints?.length ?? 0
} significant field/value pairs.`,
loadingState: i18n.translate(
'xpack.aiops.explainLogRateSpikes.loadingState.identifiedFieldValuePairs',
{
defaultMessage:
'Identified {fieldValuePairsCount, plural, one {# significant field/value pair} other {# significant field/value pairs}}.',
values: {
fieldValuePairsCount: changePoints?.length ?? 0,
},
}
),
})
);

Expand All @@ -157,14 +179,6 @@ export const defineExplainLogRateSpikesRoute = (
}

if (changePoints?.length === 0) {
push(
updateLoadingStateAction({
ccsWarning: false,
loaded: 1,
loadingState: `Done.`,
})
);

end();
return;
}
Expand Down Expand Up @@ -239,7 +253,12 @@ export const defineExplainLogRateSpikesRoute = (
updateLoadingStateAction({
ccsWarning: false,
loaded,
loadingState: `Loading histogram data.`,
loadingState: i18n.translate(
'xpack.aiops.explainLogRateSpikes.loadingState.loadingHistogramData',
{
defaultMessage: 'Loading histogram data.',
}
),
})
);
push(
Expand All @@ -255,6 +274,19 @@ export const defineExplainLogRateSpikesRoute = (
});
}

push(
updateLoadingStateAction({
ccsWarning: false,
loaded: 1,
loadingState: i18n.translate(
'xpack.aiops.explainLogRateSpikes.loadingState.doneMessage',
{
defaultMessage: 'Done.',
}
),
})
);

end();
})();

Expand Down
4 changes: 2 additions & 2 deletions x-pack/test/api_integration/apis/aiops/explain_log_rate_spikes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ export default ({ getService }: FtrProviderContext) => {
};

const expected = {
chunksLength: 12,
actionsLength: 11,
chunksLength: 13,
actionsLength: 12,
noIndexChunksLength: 4,
noIndexActionsLength: 3,
changePointFilter: 'add_change_points',
Expand Down