Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Explain log rates spikes: Fix API messages translations. #137589

Merged
merged 4 commits into from
Aug 1, 2022
Merged

[ML] Explain log rates spikes: Fix API messages translations. #137589

merged 4 commits into from
Aug 1, 2022

Conversation

walterra
Copy link
Contributor

Summary

Part of #136265.

Adds translations to API status messages to fix singular/plural issues with dynamic messages.

Checklist

@walterra walterra added bug Fixes for quality problems that affect the customer experience :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0 labels Jul 29, 2022
@walterra walterra requested a review from a team as a code owner July 29, 2022 14:04
@walterra walterra self-assigned this Jul 29, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra mentioned this pull request Jul 29, 2022
Closed
34 tasks
alvarezmelissa87
alvarezmelissa87 approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@walterra walterra added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 29, 2022
@walterra
Copy link
Contributor Author

walterra commented Aug 1, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@qn895
Copy link
Member

qn895 commented Aug 1, 2022

LGTM 🎉

@walterra walterra merged commit ee6d469 into elastic:main Aug 1, 2022
@walterra walterra deleted the ml-aiops-api-translations branch August 1, 2022 14:53
kibanamachine pushed a commit that referenced this pull request Aug 1, 2022
@walterra
[ML] Explain log rates spikes: Fix API messages translations. (#137589)
93b8f22 
Adds translations to API status messages to fix singular/plural issues with dynamic messages.

(cherry picked from commit ee6d469)
@kibanamachine kibanamachine mentioned this pull request Aug 1, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Aug 1, 2022
@kibanamachine @walterra
[ML] Explain log rates spikes: Fix API messages translations. (#137589)…
62dc715 
… (#137720)

Adds translations to API status messages to fix singular/plural issues with dynamic messages.

(cherry picked from commit ee6d469)

Co-authored-by: Walter Rafelsberger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qn895 qn895 qn895 approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees

@walterra walterra

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience ci:build-cloud-image :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0 v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@walterra @elasticmachine @kibana-ci @qn895 @kibanamachine @alvarezmelissa87