-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Detections] adds confirmation modal window for bulk exporting action #136418
Conversation
…com/vitaliidm/kibana into security-solution/bulk-edit-dry-run
…com/vitaliidm/kibana into security-solution/bulk-edit-dry-run
…com/vitaliidm/kibana into security-solution/bulk-edit-dry-run
…-ref HEAD~1..HEAD --fix'
…kibana into fix/bulk-export-modal
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
@elasticmachine merge upstream |
expected head sha didn’t match current head ref. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked out and reviewed the code changes. Leaving a bunch of comments related to quality improvements, but nothing critical.
Tested locally and it works as expected.
Thanks for working on this UX enhancement @vitaliidm!
x-pack/plugins/security_solution/cypress/integration/detection_rules/export_rule.spec.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/all/actions.ts
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/detections/pages/detection_engine/rules/all/actions.ts
Show resolved
Hide resolved
...etections/pages/detection_engine/rules/all/bulk_actions/bulk_action_dry_run_confirmation.tsx
Outdated
Show resolved
Hide resolved
...etections/pages/detection_engine/rules/all/bulk_actions/bulk_action_dry_run_confirmation.tsx
Outdated
Show resolved
Hide resolved
...olution/public/detections/pages/detection_engine/rules/all/bulk_actions/use_bulk_actions.tsx
Outdated
Show resolved
Hide resolved
...olution/public/detections/pages/detection_engine/rules/all/bulk_actions/use_bulk_actions.tsx
Outdated
Show resolved
Hide resolved
...lugins/security_solution/public/detections/pages/detection_engine/rules/all/rules_tables.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the comments @vitaliidm. The remaining ones are minor, so I'll go ahead and approve the PR. Thanks!
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @vitaliidm |
Summary
Modal windows
no rules can be exported
some rules can be exported
Implementation details
Checklist
Delete any items that are not applicable to this PR.
For maintainers
Release note
improves user experience for bulk export of security rules, by displaying confirmation modal, that show how many rules can be exported