-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Rule Export toaster message includes confusing statement "Prebuilt Rules were excluded..." #126087
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Hi @vitaliidm, is this issue fixed your recent PR here #136418 |
yes, correct @peluja1012 |
@deepikakeshav-qasource @karanbirsingh-qasource can you please validate this on latest BC? Thanks! |
Hi @MadameSheema , We have validated this issue on 8.4.0 BC2 build and observed that issue is Partially Fixed. Please find the below Testing Details: Build info
Observations:
Thanks!! |
I tested it in the @deepikakeshav-qasource my guess is it might be related to the fact that we don't refresh the page after importing rules (see #136758 and #137969). By any chance, is it possible that you had 5 custom rules, imported 4 additional custom rules and without doing a page refresh tried to export those? We will need steps to repro this in order to localize a potential bug here. If there is one, can we please open a new GH issue for it and close this one? I think we addressed the original issue of having a confusing statement in the toast. |
Hi @banderror , We have not import any rule while testing out this ticket. However, We have created the new build today and tested out this scenario and the issue is not occurring on it. but on my old build 8.4.0 bc2 issue is still occurring. We have reported the new issue. Hence, we are closing this issue. Moreover, We have shared this build details over slack. Please let us know if anything else is required from our end!! Thanks!! |
Kibana version: 8.1.0 BC1
Elasticsearch version: 8.1.0 BC1
Server OS version: Elastic Cloud ESS default
Browser version: Google Chrome Version 98.0.4758.102 (Official Build) (x86_64)
Browser OS version: macOS Monterey Version 12.2.1 (21D62)
Original install method (e.g. download page, yum, from source, etc.): Elastic Cloud ESS GCP Europe-West-1
Describe the bug:
When exporting custom rules, toaster messages says that prebuilt rules were excluded. Confuses me since I did not select any prebuilt rules.
Steps to reproduce:
Expected behavior:
Sentence about the prebuilt rules should not appear, since I did not select any prebuilt rules for export.
Screenshots (if relevant):
Errors in browser console (if relevant): None
Provide logs and/or server output (if relevant): N/A
Any additional context: This is not a new behavior in 8.1.0, AFAIK
cc: @jethr0null
The text was updated successfully, but these errors were encountered: