Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Explain log rate spikes: Add TODO comments about possible code consolidation. #136181

Merged
merged 1 commit into from
Jul 12, 2022
Merged

[ML] Explain log rate spikes: Add TODO comments about possible code consolidation. #136181

merged 1 commit into from
Jul 12, 2022

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Jul 12, 2022 •
edited
Loading

Summary

Part of #136265.

Adds TODO comments to aiops API related files with potential for code consolidation into distinct packages. The original code for the analysis has a lot in common with APM correlations.

Checklist

@walterra walterra added :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jul 12, 2022
@walterra walterra self-assigned this Jul 12, 2022
@walterra walterra requested a review from a team as a code owner July 12, 2022 09:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@walterra walterra merged commit b65f0bd into elastic:main Jul 12, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 12, 2022
@walterra walterra deleted the ml-aiops-api-todo-comments branch July 12, 2022 11:15
@walterra walterra mentioned this pull request Jul 12, 2022
Open
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@walterra walterra

Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walterra @elasticmachine @kibana-ci @peteharverson @kibanamachine