[ML] Add TODO comments about possible code consolidation. (#136181)

elastic · Jul 12, 2022 · b65f0bd · b65f0bd
1 parent 2de673f
commit b65f0bd
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/x-pack/packages/ml/aiops_components/src/progress_controls/progress_controls.tsx b/x-pack/packages/ml/aiops_components/src/progress_controls/progress_controls.tsx
@@ -10,6 +10,9 @@ import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n-react';
 import React from 'react';
 
+// TODO Consolidate with duplicate component `CorrelationsProgressControls` in
+// `x-pack/plugins/apm/public/components/app/correlations/progress_controls.tsx`
+
 interface ProgressControlProps {
   progress: number;
   progressMessage: string;

diff --git a/x-pack/plugins/aiops/server/routes/queries/fetch_change_point_p_values.ts b/x-pack/plugins/aiops/server/routes/queries/fetch_change_point_p_values.ts
@@ -15,6 +15,9 @@ import { ChangePoint } from '../../../common/types';
 import { getQueryWithParams } from './get_query_with_params';
 import { getRequestBase } from './get_request_base';
 
+// TODO Consolidate with duplicate `fetchDurationFieldCandidates` in
+// `x-pack/plugins/apm/server/routes/correlations/queries/fetch_failed_events_correlation_p_values.ts`
+
 export const getChangePointRequest = (
   params: AiopsExplainLogRateSpikesSchema,
   fieldName: string

diff --git a/x-pack/plugins/aiops/server/routes/queries/fetch_field_candidates.ts b/x-pack/plugins/aiops/server/routes/queries/fetch_field_candidates.ts
@@ -16,6 +16,9 @@ import type { AiopsExplainLogRateSpikesSchema } from '../../../common/api/explai
 import { getQueryWithParams } from './get_query_with_params';
 import { getRequestBase } from './get_request_base';
 
+// TODO Consolidate with duplicate `fetchPValues` in
+// `x-pack/plugins/apm/server/routes/correlations/queries/fetch_duration_field_candidates.ts`
+
 const POPULATED_DOC_COUNT_SAMPLE_SIZE = 1000;
 
 const SUPPORTED_ES_FIELD_TYPES = [