Fixes #13246 - Add checks for empty annotations #13422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
v6.0.0
v6.0.0-beta2
Feature:TSVB
thomasneirynck
approved these changes
Aug 10, 2017
| @@ -30,7 +30,7 @@ export default (req, panel) => { | |||
| return bodies; | |||
| }); | |||
|
|
|||
| if (!bodies.length) return { responses: [] }; | |||
| if (!bodies.length) return Promise.resolve({ responses: [] }); | |||
There was a problem hiding this comment.
while we're in here anyway, consider flagging the get_annotations function as async instead. it avoids boilerplate like this and babel will give us some more compile-time safety. not sure how far this will cascade though....
There was a problem hiding this comment.
I refactored this file to use async/await
simianhacker
added a commit
that referenced
this pull request
Aug 10, 2017
simianhacker
added a commit
that referenced
this pull request
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #13246 by adding a check to make sure there are actual annotations in the annotations array. It also returns a promise for
getAnnotations()instead of just an object when request is empty due to the lack of any valid annotations.