Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing all annotations from a TSVB vis breaks the vis #13246

Closed
marius-dr opened this issue Aug 1, 2017 · 0 comments · Fixed by #13422
Closed

Removing all annotations from a TSVB vis breaks the vis #13246

marius-dr opened this issue Aug 1, 2017 · 0 comments · Fixed by #13422
Assignees
@simianhacker
Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available)

Comments

@marius-dr
Copy link
Member

Kibana version: 6.0.0-beta1

Browser version: IE 11

Description of the problem including expected versus actual behavior:
If you remove all annotations from a TSVB visualization that was already working properly, it will stop working and display "The request for this panel failed"
After comparing the 2 requests (one with no annotations ever added and another with all annotations removed), I can see that the difference between the requests is an extra ,"annotations":[] in the second case, which causes the request to fail.

Steps to reproduce:

  1. Create a new TSVB visualization.
  2. Add a data source in the Annotations tab.
  3. Remove that data source that you just added.
    The visualization will look like this after step 3.
    tsvb
@marius-dr marius-dr added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience labels Aug 1, 2017
@thomasneirynck thomasneirynck added the Feature:TSVB TSVB (Time Series Visual Builder) label Aug 1, 2017
simianhacker added a commit to simianhacker/kibana that referenced this issue Aug 9, 2017
@simianhacker
Fixes elastic#13246 - Add checkes for empty annotations
720164d
@simianhacker simianhacker mentioned this issue Aug 9, 2017
Merged
@simianhacker simianhacker self-assigned this Aug 9, 2017
simianhacker added a commit that referenced this issue Aug 10, 2017
@simianhacker
Fixes #13246 - Add checks for empty annotations (#13422)
17fcaf1 
* Fixes #13246 - Add checkes for empty annotations

* Refactoring get_annotations to use async/await
simianhacker added a commit that referenced this issue Aug 10, 2017
@simianhacker
Fixes #13246 - Add checks for empty annotations (#13422)
b80e970 
* Fixes #13246 - Add checkes for empty annotations

* Refactoring get_annotations to use async/await
simianhacker added a commit that referenced this issue Aug 10, 2017
@simianhacker
Fixes #13246 - Add checks for empty annotations (#13422)
7cc9d5d 
* Fixes #13246 - Add checkes for empty annotations

* Refactoring get_annotations to use async/await
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simianhacker simianhacker

Labels
bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #13246 - Add checks for empty annotations simianhacker/kibana
3 participants
@simianhacker @thomasneirynck @marius-dr