Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Use shared versions file for doc builds #13277

Merged
merged 2 commits into from
Aug 11, 2017
Merged

[DOCS] Use shared versions file for doc builds #13277

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c84812c
[DOCS] Use shared versions file for doc builds
lcawl Aug 1, 2017
2d7c7d1
[DOCS] Address feedback in index-shared1.asciidoc
lcawl Aug 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions docs/index-shared1.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,4 @@

//////////
release-state can be: released | prerelease | unreleased
//////////
:release-state: released
:version: 5.5.1
:major-version: 5.x
:branch: 5.5

:docker-image: docker.elastic.co/kibana/kibana:{version}
:repo: https://github.com/elastic/kibana/
:issue: {repo}issues/
Expand All @@ -15,6 +7,7 @@ release-state can be: released | prerelease | unreleased
:blob: {repo}blob/{branch}/
:security-ref: https://www.elastic.co/community/security/

include::{asciidoc-dir}/../../shared/versions55.asciidoc[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for these values to be accessible when creating the above kibana-specific variables like :docker-image:, which relies on {version}, I think this include needs to happen at the top of the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, you're right! Done!

include::{asciidoc-dir}/../../shared/attributes.asciidoc[]

include::introduction.asciidoc[]
Expand Down