[DOCS] Use shared versions file for doc builds #13277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epixa
suggested changes
Aug 9, 2017
docs/index-shared1.asciidoc
Outdated
| @@ -15,6 +7,7 @@ release-state can be: released | prerelease | unreleased | |||
| :blob: {repo}blob/{branch}/ | |||
| :security-ref: https://www.elastic.co/community/security/ | |||
|
|
|||
| include::{asciidoc-dir}/../../shared/versions55.asciidoc[] | |||
There was a problem hiding this comment.
In order for these values to be accessible when creating the above kibana-specific variables like :docker-image:, which relies on {version}, I think this include needs to happen at the top of the file.
There was a problem hiding this comment.
Oops, you're right! Done!
epixa
approved these changes
Aug 11, 2017
lcawl
added a commit
that referenced
this pull request
Aug 11, 2017
* [DOCS] Use shared versions file for doc builds * [DOCS] Address feedback in index-shared1.asciidoc
lcawl
added a commit
that referenced
this pull request
Aug 11, 2017
* [DOCS] Use shared versions file for doc builds * [DOCS] Address feedback in index-shared1.asciidoc
lcawl
added a commit
that referenced
this pull request
Aug 11, 2017
* [DOCS] Use shared versions file for doc builds * [DOCS] Address feedback in index-shared1.asciidoc
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Aug 11, 2017
* [DOCS] Use shared versions file for doc builds * [DOCS] Address feedback in index-shared1.asciidoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the Kibana User Guide documentation build so that it pulls version information from a shared file in elastic/docs/shared repository. This allows versioning information to be updated more uniformly and quickly across many books.
The X-Pack Reference already uses those shared files successfully and other books will be migrated to use them as well. See elastic/elasticsearch#26004