Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Posture] Update latest findings index mapping #131504

Merged
merged 16 commits into from
May 18, 2022
Merged

[Cloud Posture] Update latest findings index mapping #131504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4b43815
update latest findings mapping
uri-weisman May 4, 2022
ecaf839
Merge branch 'main' into update_findings_mapping
uri-weisman May 4, 2022
f4631c3
Merge branch 'main' into update_findings_mapping
uri-weisman May 4, 2022
5ab8a37
Merge branch 'main' into update_findings_mapping
uri-weisman May 8, 2022
9c35f52
update types
uri-weisman May 12, 2022
b255512
Merge branch 'main' into update_findings_mapping
uri-weisman May 12, 2022
6b2d34f
use ecs convention for multi fields
uri-weisman May 15, 2022
148ac5b
Merge branch 'update_findings_mapping' of https://github.com/uri-weis…
uri-weisman May 15, 2022
f03fc66
Merge branch 'main' into update_findings_mapping
kibanamachine May 15, 2022
54b3cb4
update types
uri-weisman May 15, 2022
22b4bf3
Merge branch 'update_findings_mapping' of https://github.com/uri-weis…
uri-weisman May 15, 2022
6719070
Merge branch 'main' into update_findings_mapping
kibanamachine May 15, 2022
b5fd66f
Revert "use ecs convention for multi fields"
uri-weisman May 16, 2022
345281e
update mapping
uri-weisman May 17, 2022
4d1ae22
Merge branch 'main' into update_findings_mapping
uri-weisman May 17, 2022
a16b937
Merge branch 'update_findings_mapping' of https://github.com/uri-weis…
uri-weisman May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/cloud_security_posture/public/pages/findings/findings_flyout/resource_tab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const getDescriptionDisplay = (value: unknown) => {
return <EuiText size="s">{value as string}</EuiText>;
};

export const prepareDescriptionList = (data: Record<string, unknown>) =>
export const prepareDescriptionList = (data: any) =>
Object.entries(getFlattenedObject(data))
.sort((a, b) => a[0].localeCompare(b[0]))
.map(([key, value]) => ({
Expand Down
7 changes: 3 additions & 4 deletions ...oud_security_posture/public/pages/findings/latest_findings/latest_findings_table.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,10 @@ const getFakeFindings = (name: string): CspFinding & { id: string } => ({
},
resource: {
name: chance.string(),
filename: chance.string(),
type: chance.string(),
path: chance.string(),
uid: chance.string(),
mode: chance.string(),
raw: {} as any,
sub_type: chance.string(),
id: chance.string(),
},
cycle_id: chance.string(),
host: {} as any,
Expand Down
10 changes: 4 additions & 6 deletions x-pack/plugins/cloud_security_posture/public/pages/findings/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,11 @@ interface CspFindingResult {
}

interface CspFindingResource {
uid: string;
filename: string;
// gid: string;
mode: string;
path: string;
type: string;
name: string;
sub_type: string;
raw: object;
id: string;
type: string;
[other_keys: string]: unknown;
}

Expand Down
23 changes: 14 additions & 9 deletions x-pack/plugins/cloud_security_posture/server/create_indices/latest_findings_mapping.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export const latestFindingsMapping: MappingTypeMapping = {
},
},
},

agent: {
properties: {
id: {
Expand Down Expand Up @@ -49,16 +48,17 @@ export const latestFindingsMapping: MappingTypeMapping = {
},
resource: {
properties: {
filename: {
type: {
type: 'keyword',
ignore_above: 256,
},
id: {
type: 'text',
fields: {
keyword: {
ignore_above: 1024,
type: 'keyword',
},
},
},
type: {
name: {
type: 'text',
},
sub_type: {
type: 'text',
fields: {
keyword: {
Expand All @@ -67,9 +67,14 @@ export const latestFindingsMapping: MappingTypeMapping = {
},
},
},
raw: {
type: 'object',
enabled: false,
},
},
},
resource_id: {
// deprecated - the new field is resource.id
type: 'text',
fields: {
keyword: {
Expand Down