-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Posture] Update latest findings index mapping #131504
[Cloud Posture] Update latest findings index mapping #131504
Conversation
related: elastic/cloudbeat#69 |
@@ -49,7 +48,25 @@ export const latestFindingsMapping: MappingTypeMapping = { | |||
}, | |||
resource: { | |||
properties: { | |||
filename: { | |||
type: { | |||
type: 'text', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, just a thought. If we are introducing new fields worth discussing if it is a good point to shift to ECS convention for text fields https://www.elastic.co/guide/en/ecs/8.2/ecs-conventions.html#_ecs_convention_for_indexing_text_fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I'll update the mapping according to the ECS convention.
maybe update |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this requires updating our queries, otherwise it will break our UI
This reverts commit 6b2d34f.
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
Due to a change in the cloudbeat events shifted to ES, index mapping should be updated.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers