Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete data views from list visible for read users #131473

Merged
merged 2 commits into from
May 4, 2022

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented May 3, 2022

Summary

Hide data view selection for roles without data view editing privledges as its only used for deleting.

Closes #130781

@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 bug Fixes for quality problems that affect the customer experience Team:AppServicesSv v8.3.0 v8.2.1 labels May 3, 2022
@mattkime mattkime marked this pull request as ready for review May 3, 2022 23:55
@mattkime mattkime requested a review from a team as a code owner May 3, 2022 23:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@mattkime mattkime added the release_note:skip Skip the PR/issue when compiling release notes label May 3, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewManagement 124.0KB 124.0KB +26.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @shivindera

@mattkime mattkime added the auto-backport Deprecated - use backport:version if exact versions are needed label May 4, 2022
@mattkime mattkime merged commit dc52980 into elastic:main May 4, 2022
kibanamachine pushed a commit that referenced this pull request May 4, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 4, 2022
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Data Views Data Views code and UI - index patterns before 8.0 release_note:skip Skip the PR/issue when compiling release notes v8.2.1 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete data views from list visible for read users
5 participants