Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] [Debug UI] Implement "Preconfiguration debugger" UI #131436

Merged

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented May 3, 2022

Summary

Feature Branch PR: #131322

Adds a preconfiguration debugger for selecting and resetting preconfigured policies or bulk resetting all preconfigured policies.

Screen Recording

Screen.Recording.2022-05-03.at.1.52.16.PM.mov

@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0 labels May 3, 2022
@kpollich kpollich requested a review from juliaElastic May 3, 2022 17:54
@kpollich kpollich requested a review from a team as a code owner May 3, 2022 17:54
@kpollich kpollich self-assigned this May 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kpollich
Copy link
Member Author

kpollich commented May 3, 2022

Not pictured in screen recording: code block for selected policy added in 675fd83

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
fleet 668 669 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1275 1278 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 772.2KB 775.4KB +3.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 91.2KB 91.7KB +596.0B
Unknown metric groups

API count

id before after diff
fleet 1394 1397 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kpollich

@kpollich kpollich merged commit 44877db into elastic:feature/fleet-debug-page May 4, 2022
@kpollich kpollich deleted the preconfiguration-debugger branch May 4, 2022 12:17
kpollich added a commit that referenced this pull request Jun 21, 2022
* Bootstrap Fleet /_debug route + React Query

* [Fleet] [Debug UI] Implement "Agent Policy Debugger" UI (#131335)

* Add initial agent policy debugger module

* Fix clear button in agent policy select

* Implement deletion of selected policy

* Fix layout of combo-box/button

* Add searchable ID to agent policy labels

* Add description text to debugger module

* Fixup loading/error logic

* [Fleet] Saved Objects Debugger (#131370)

* saved objects debugger

* converted so names to combobox

* types fix

* extracted combo box component

* fixed error display

* [Fleet] [Debug UI] Implement "Integration Debugger" UI (#131354)

* Implement integrations debugger UI

* Clean up + add link to integration settings

* Add divider below integration debugger

* Clean up loading states

* Fix flex spacing for saved objects debugger

* [Fleet] Added fleet indices query to debug UI (#131395)

* fleet indices

* keeping the type and name combo close in saved objects

* fixed prettier

* removed useEffects, simplified use of useQuery (#131482)

* using different query for saved objects (#131491)

* [Fleet] [Debug UI] Implement "Preconfiguration debugger" UI (#131436)

* Implement preconfiguration debugger UI

* Add code block view

* Added missing newline

Co-authored-by: Julia Bardi <[email protected]>

* Prevent flicker in saved objects code block

* added links including health check report (#131503)

* added links including health check report

* experiment with accordion

Co-authored-by: Kibana Machine <[email protected]>

* Refactor panel rendering + danger zone callout

* Convert panels to all singular

* confirm modal for reset preconfig (#131596)

* Add icons to useful links + fix reset all -> title case

* Fix disabled health check link

* added orphaned policies api and to debug page (#131697)

* Language fixes around orphaned policy module

* Add some basic dev docs around the debugger

* increasing page load bundle limit slightly (#132690)

* Remove health check link as it's not implemented

* Fix agents link + disable reset all button when no preconfigured policies

* Update doc title on debug page

* Translate everything

* Remove delete orphaned endpoint + fix force flag in existing delete endpoint

* Fix type

* Add API integration tests for orphaned policies

Co-authored-by: Julia Bardi <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants