-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] [Debug UI] Implement "Integration Debugger" UI #131354
Merged
kpollich
merged 5 commits into
elastic:feature/fleet-debug-page
from
kpollich:integrations-module
May 3, 2022
Merged
[Fleet] [Debug UI] Implement "Integration Debugger" UI #131354
kpollich
merged 5 commits into
elastic:feature/fleet-debug-page
from
kpollich:integrations-module
May 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/fleet (Team:Fleet) |
Code looks good so far, haven't checked locally yet. |
c09dfa7
to
e228465
Compare
juliaElastic
reviewed
May 3, 2022
...k/plugins/fleet/public/applications/fleet/sections/debug/components/integration_debugger.tsx
Show resolved
Hide resolved
juliaElastic
approved these changes
May 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, commented one small bug
💔 Build FailedFailed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @kpollich |
28 tasks
kpollich
added a commit
that referenced
this pull request
Jun 21, 2022
* Bootstrap Fleet /_debug route + React Query * [Fleet] [Debug UI] Implement "Agent Policy Debugger" UI (#131335) * Add initial agent policy debugger module * Fix clear button in agent policy select * Implement deletion of selected policy * Fix layout of combo-box/button * Add searchable ID to agent policy labels * Add description text to debugger module * Fixup loading/error logic * [Fleet] Saved Objects Debugger (#131370) * saved objects debugger * converted so names to combobox * types fix * extracted combo box component * fixed error display * [Fleet] [Debug UI] Implement "Integration Debugger" UI (#131354) * Implement integrations debugger UI * Clean up + add link to integration settings * Add divider below integration debugger * Clean up loading states * Fix flex spacing for saved objects debugger * [Fleet] Added fleet indices query to debug UI (#131395) * fleet indices * keeping the type and name combo close in saved objects * fixed prettier * removed useEffects, simplified use of useQuery (#131482) * using different query for saved objects (#131491) * [Fleet] [Debug UI] Implement "Preconfiguration debugger" UI (#131436) * Implement preconfiguration debugger UI * Add code block view * Added missing newline Co-authored-by: Julia Bardi <[email protected]> * Prevent flicker in saved objects code block * added links including health check report (#131503) * added links including health check report * experiment with accordion Co-authored-by: Kibana Machine <[email protected]> * Refactor panel rendering + danger zone callout * Convert panels to all singular * confirm modal for reset preconfig (#131596) * Add icons to useful links + fix reset all -> title case * Fix disabled health check link * added orphaned policies api and to debug page (#131697) * Language fixes around orphaned policy module * Add some basic dev docs around the debugger * increasing page load bundle limit slightly (#132690) * Remove health check link as it's not implemented * Fix agents link + disable reset all button when no preconfigured policies * Update doc title on debug page * Translate everything * Remove delete orphaned endpoint + fix force flag in existing delete endpoint * Fix type * Add API integration tests for orphaned policies Co-authored-by: Julia Bardi <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v8.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Branched off of #131335 - so needs to be rebased once #131335 lands in order to merge cleanly.
Adds an Integration Debugger that allows users to
Integrations with active agents are non-removable, so they will report an error when attempting to uninstall/reinstall.
Screen Recording
Screen.Recording.2022-05-03.at.9.18.38.AM.mov