Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XY] Detailed tooltip. #131116

Merged

Conversation

Kuznietsov
Copy link
Contributor

@Kuznietsov Kuznietsov commented Apr 28, 2022

Summary

Completes #128056 and part of #127115


Detailed endzone tooltip with value:

Screen.Recording.2022-05-31.at.10.37.26.mov

Detailed endzone tooltip without value:

Screen.Recording.2022-05-31.at.10.40.51.mov

Plain detailed tooltip:

Screen.Recording.2022-05-31.at.10.47.41.mov

Testing notes:

layeredXyVis expression example (need to add Time filter for the chart to work):

layeredXyVis xTitle="" yTitle="" yRightTitle="" legend={legendConfig isVisible=true  position="right"       shouldTruncate=true} fittingFunction="None" endValue="None" emphasizeFitting=false curveType="LINEAR" fillOpacity=0.3 yLeftExtent={axisExtentConfig mode="full"} yRightExtent={axisExtentConfig mode="full"} yLeftScale="linear" yRightScale="linear" 
  axisTitlesVisibilitySettings={axisTitlesVisibilityConfig x=true yLeft=true yRight=true} tickLabelsVisibilitySettings={tickLabelsConfig x=true yLeft=true yRight=true} gridlinesVisibilitySettings={gridlinesConfig x=true yLeft=true yRight=true} labelsOrientation={labelsOrientationConfig x=0 yLeft=0 yRight=0} valueLabels="hide" hideEndzones=false valuesInLegend=false 
  layers={extendedDataLayer layerId="233e7aec-5303-479a-bffc-ad5c1ab23a90" hide=false xAccessor="4e055ae6-445c-459b-8705-66da3bf32a2a" xScaleType="time" isHistogram=true   seriesType="bar_stacked" accessors="64963192-d828-4a43-ba42-3fd5eaf468b7" columnToLabel="{\"64963192-d828-4a43-ba42-3fd5eaf468b7\":\"Count of records\"}" table={kibana | esaggs index={indexPatternLoad id="90943e30-9a47-11e8-b64d-95841ca0b247"} aggs={aggDateHistogram id="0" enabled=true schema="segment" field="@timestamp" useNormalizedEsInterval=true interval="auto" drop_partials=false min_doc_count=0 extended_bounds={extendedBounds} extendToTimeRange=true} aggs={aggCount id="1" enabled=true schema="metric" emptyAsNull=true} metricsAtAllLevels=false partialRows=false timeFields="@timestamp" | lens_rename_columns idMap="{\"col-0-0\":{\"label\":\"@timestamp\",\"dataType\":\"date\",\"operationType\":\"date_histogram\",\"sourceField\":\"@timestamp\",\"isBucketed\":true,\"scale\":\"interval\",\"params\":{\"interval\":\"auto\",\"includeEmptyRows\":true,\"dropPartials\":false},\"id\":\"4e055ae6-445c-459b-8705-66da3bf32a2a\"},\"col-1-1\":{\"label\":\"Count of records\",\"dataType\":\"number\",\"operationType\":\"count\",\"isBucketed\":false,\"scale\":\"ratio\",\"sourceField\":\"___records___\",\"params\":{\"emptyAsNull\":true},\"id\":\"64963192-d828-4a43-ba42-3fd5eaf468b7\"}}"} palette={system_palette name="default"}} detailedTooltip=true

xyVis expression example:

kibana
| selectFilter
| demodata
| head 15
| xyVis seriesType="area" detailedTooltip=true xAccessor="project" accessors={visdimension "percent_uptime" format="percent"}
| render

@Kuznietsov Kuznietsov added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. NeededFor:Canvas Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.3.0 backport:skip This commit does not require backporting and removed WIP Work in progress labels May 31, 2022
@Kuznietsov Kuznietsov marked this pull request as ready for review May 31, 2022 08:25
@Kuznietsov Kuznietsov requested review from a team as code owners May 31, 2022 08:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@Kuznietsov Kuznietsov requested a review from flash1293 May 31, 2022 08:27
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
expressionXY 100 111 +11

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
expressionXY 136 137 +1
lens 509 510 +1
total +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionXY 86.7KB 96.5KB +9.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionXY 32.7KB 32.9KB +198.0B
Unknown metric groups

API count

id before after diff
expressionXY 146 147 +1
lens 586 587 +1
total +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Kunzetsov

@flash1293
Copy link
Contributor

In Lens, axis title "none" is not respected anymore:
Screenshot 2022-06-01 at 10 35 39

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, LGTM

@Kuznietsov
Copy link
Contributor Author

@elastic/kibana-design, could you, please, review this PR? Thanks a lot.

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, LGTM

@Kuznietsov Kuznietsov added v8.4.0 and removed v8.3.0 labels Jun 1, 2022
@Kuznietsov
Copy link
Contributor Author

Kuznietsov commented Jun 1, 2022

@elastic/kibana-design, could you, please, review this PR? Thanks a lot.

Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kuznietsov Kuznietsov merged commit ca36c6d into elastic:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Canvas Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort release_note:enhancement Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants