Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XY] xyVis and layeredXyVis layers. #128056

Closed
7 tasks done
Kuznietsov opened this issue Mar 18, 2022 · 5 comments
Closed
7 tasks done

[XY] xyVis and layeredXyVis layers. #128056

Kuznietsov opened this issue Mar 18, 2022 · 5 comments
Assignees
Labels
Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. NeededFor:VisEditors Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@Kuznietsov
Copy link
Contributor

Kuznietsov commented Mar 18, 2022

xyVis

  • Remove layers. They will be supported at the layeredXyVis.
  • Add referenceLineLayers argument, which is accepting dataLayer type.
  • And referenceLineLayers argument, which is accepting referenceLineLayer type.
  • And referenceLineLayers argument, which is accepting annotationLayer type.
  • Add extendedDataLayer expression function, which is supporting optional table argument. If table is not provided, the input should be used.
  • Add extendedReferenceLayer expression function, which is supporting optional table argument. If table is not provided, the input should be used.

layeredXyVis

  • Add layers argument, which is supporting extendedDataLayer, extendedReferenceLayer and extendedAnnotationLayer expression function types.
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 18, 2022
@Kuznietsov Kuznietsov changed the title Split xyVis and layeredXyVis. xyVis should accept own arguments + lens_xy_layer arguments or one layer argument, which accepts lens_xy_layer type, which doesn't have table argument. layeredXyVis should accept multiple layer arguments of extended lens_xy_layer type with table argument. (author: @Kunzetsov) [XY] xyVis layers. Mar 18, 2022
@Kuznietsov Kuznietsov changed the title [XY] xyVis layers. [XY] xyVis and layeredXyVis layers. Mar 18, 2022
@Kuznietsov Kuznietsov self-assigned this Mar 18, 2022
@Kuznietsov Kuznietsov added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens NeededFor:VisEditors labels Mar 18, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 18, 2022
@stratoula
Copy link
Contributor

Just a note and maybe it worths adding it here. Lens is going to support another layer type, the annotations. The PR is WIP #126456 but good to have it in mind.

@Kuznietsov
Copy link
Contributor Author

@stratoula, updated the issue.

@flash1293
Copy link
Contributor

@Kunzetsov Can you elaborate on why we need dataLayer and extendedDataLayer? What about having only dataLayer with on optional argument which is used when provided? It seems like the two types make it harder for a user to choose the right thing.

@Kuznietsov
Copy link
Contributor Author

Kuznietsov commented Mar 21, 2022

@flash1293, xyVis, which will be used at Canvas and VisEditors, is accepting dataLayer, referenceLineLayer and annotationLayer input types (without table argument) for dataLayer, referenceLineLayer and annotationLayer arguments. At the same time, layerXyVis, which will be used only at Lens, is accepting extendedDataLayer, extendedReferenceLineLayer and extendedAnnotationLayer, which have optional table argument. So, for xyVis user will not have any options 😃

@flash1293
Copy link
Contributor

@Kunzetsov Ah, I see, that makes sense, thanks for explaining.

@exalate-issue-sync exalate-issue-sync bot reopened this May 3, 2022
@exalate-issue-sync exalate-issue-sync bot added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. NeededFor:VisEditors Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants