Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Unblocks main #130771

Merged
merged 2 commits into from
Apr 21, 2022
Merged

[Security Solution] Unblocks main #130771

merged 2 commits into from
Apr 21, 2022

Conversation

MadameSheema
Copy link
Member

Summary

The following issues are blocking main since are making some of our Cypress tests fail:

In this PR we are commenting some assertions and skipping some tests in order to unblock main.

@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team v8.3.0 labels Apr 21, 2022
@MadameSheema MadameSheema self-assigned this Apr 21, 2022
@MadameSheema MadameSheema requested review from a team as code owners April 21, 2022 09:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema enabled auto-merge (squash) April 21, 2022 09:32
banderror
banderror approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I appreciate your help with this @MadameSheema

@banderror banderror added failed-test A test failure on a tracked branch, potentially flaky-test skipped-test labels Apr 21, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit 58acda6 into elastic:main Apr 21, 2022
@liza-mae liza-mae mentioned this pull request Apr 21, 2022
Merged
@banderror banderror mentioned this pull request Apr 21, 2022
Closed
@MadameSheema MadameSheema deleted the cypress/unblock-main branch May 16, 2022 07:56
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@MadameSheema @kertal
unblocks main (elastic#130771)
1c991dd
@banderror
Copy link
Contributor

The tests have been unskipped in #132834

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banderror banderror banderror approved these changes

@janmonschke janmonschke janmonschke approved these changes

Assignees

@MadameSheema MadameSheema

Labels
failed-test A test failure on a tracked branch, potentially flaky-test release_note:skip Skip the PR/issue when compiling release notes skipped-test Team:Detection Rule Management Security Detection Rule Management Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MadameSheema @elasticmachine @kibana-ci @banderror @janmonschke