Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Define rule, About rule, Schedule rule and Rule actions steps wiped during rule creation #130767

Closed
MadameSheema opened this issue Apr 21, 2022 · 5 comments · Fixed by #132834 or #133160
Closed

[Security Solution] Define rule, About rule, Schedule rule and Rule actions steps wiped during rule creation #130767

MadameSheema opened this issue Apr 21, 2022 · 5 comments · Fixed by #132834 or #133160
Assignees
@banderror @nkhristinin
Labels
8.3 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Creation Security Solution Detection Rule Creation workflow fixed impact:critical This issue should be addressed immediately due to a critical level of impact on the product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.3.0

Comments

@MadameSheema
Copy link
Member

MadameSheema commented Apr 21, 2022 •
edited by banderror
Loading

Describe the bug:

  • [Security Solution] Define rule, About rule, Schedule rule and Rule actions steps wiped during rule creation when you try to edit one of them

Kibana/Elasticsearch Stack version:

Steps to reproduce:

  1. Navigate to rules page
  2. Fill all the mandatory fields
  3. Edit one of the steps

Current behavior:

  • The step values has been wiped out and reset to the default one

Expected behavior:

  • The step values should maintain the entered values

Additional information:

  • This issue is making our Cypress tests fail blocking other teams, so I suspect it might be introduced by a change on one of the components we use.
@MadameSheema MadameSheema added bug Fixes for quality problems that affect the customer experience triage_needed Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team labels Apr 21, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@MadameSheema MadameSheema mentioned this issue Apr 21, 2022
Merged
@banderror banderror added Feature:Rule Management Security Solution Detection Rule Management area and removed triage_needed labels Apr 21, 2022
@banderror
Copy link
Contributor

So this is happening when you:

  • Open a Rule Creation page
  • Fill in the form fields of any step, click Continue
  • Go back to this or any other step (click Edit on it)

Then you can observe that form fields in the latter step are cleared.

@banderror banderror mentioned this issue Apr 21, 2022
Closed
@banderror banderror linked a pull request Apr 21, 2022 that will close this issue
[Security Solution][Detections] Fix rule creation/editing forms #130825
Closed
@MadameSheema MadameSheema mentioned this issue Apr 25, 2022
Closed
@banderror banderror added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. 8.3 candidate v8.3.0 labels Apr 26, 2022
@peluja1012 peluja1012 added Feature:Rule Creation Security Solution Detection Rule Creation workflow and removed Feature:Rule Management Security Solution Detection Rule Management area labels May 19, 2022
@banderror banderror mentioned this issue May 24, 2022
Merged
2 tasks
@nkhristinin nkhristinin mentioned this issue May 25, 2022
Merged
1 task
banderror pushed a commit that referenced this issue May 30, 2022
@nkhristinin
Security form fix (#132834)
52bdf9a 
**Addresses:** #130767, #130770

Related to [this PR](#130825).

@banderror described the reason for the problems in his PR. There was [ask ](#130825 (review)) to not return the `useEffect` to the form lib.

The fix of the form clears the values [in this commit](df0b7bb)

Then I cherry-pick commits from @banderror PR to fix form stripping undefined values and also fixed some tests

### Checklist

Delete any items that are not applicable to this PR.

- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@banderror banderror removed a link to a pull request May 30, 2022
[Security Solution][Detections] Fix rule creation/editing forms #130825
Closed
@banderror banderror linked a pull request May 30, 2022 that will close this issue
Security form fix #132834
Merged
1 task
kibanamachine pushed a commit that referenced this issue May 30, 2022
@nkhristinin
Security form fix (#132834)
2badeea 
**Addresses:** #130767, #130770

Related to [this PR](#130825).

@banderror described the reason for the problems in his PR. There was [ask ](#130825 (review)) to not return the `useEffect` to the form lib.

The fix of the form clears the values [in this commit](df0b7bb)

Then I cherry-pick commits from @banderror PR to fix form stripping undefined values and also fixed some tests

### Checklist

Delete any items that are not applicable to this PR.

- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

(cherry picked from commit 52bdf9a)
@banderror
Copy link
Contributor

Fixed in #132834

banderror pushed a commit to banderror/kibana that referenced this issue May 30, 2022
@nkhristinin @banderror
Security form fix (elastic#132834)
c138f0e 
**Addresses:** elastic#130767, elastic#130770

Related to [this PR](elastic#130825).

@banderror described the reason for the problems in his PR. There was [ask ](elastic#130825 (review)) to not return the `useEffect` to the form lib.

The fix of the form clears the values [in this commit](elastic@df0b7bb)

Then I cherry-pick commits from @banderror PR to fix form stripping undefined values and also fixed some tests

### Checklist

Delete any items that are not applicable to this PR.

- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

(cherry picked from commit 52bdf9a)
@banderror banderror linked a pull request May 30, 2022 that will close this issue
[8.3] Security form fix (#132834) #133160
Merged
kibanamachine added a commit that referenced this issue May 30, 2022
@kibanamachine @nkhristinin
Security form fix (#132834) (#133160)
7577370 
**Addresses:** #130767, #130770

Related to [this PR](#130825).

@banderror described the reason for the problems in his PR. There was [ask ](#130825 (review)) to not return the `useEffect` to the form lib.

The fix of the form clears the values [in this commit](df0b7bb)

Then I cherry-pick commits from @banderror PR to fix form stripping undefined values and also fixed some tests

### Checklist

Delete any items that are not applicable to this PR.

- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

(cherry picked from commit 52bdf9a)

Co-authored-by: Khristinin Nikita <[email protected]>
@ghost
Copy link

ghost commented Jun 3, 2022 •
edited by ghost
Loading

Hi @MadameSheema ,

We have validated above issue on 8.3.0 BC2 and it's fixed. 🟢

Build Details:

Version: 8.3.0 BC2
Build: 53231
Commit: 25476b531ba9f32292bde85508d342aa5e1c29eb

Screen records:

KaranVM.1.-.ec2-54-174-127-137.compute-1.amazonaws.com.-.Remote.Desktop.Connection.2022-06-03.13-15-18.mp4

Hence, we are closing this issue and marking this as QA Validated.

Thanks !

@ghost ghost closed this as completed Jun 3, 2022
@ghost ghost added the QA:Validated Issue has been validated by QA label Jun 3, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@banderror banderror

@nkhristinin nkhristinin

Labels
8.3 candidate bug Fixes for quality problems that affect the customer experience Feature:Rule Creation Security Solution Detection Rule Creation workflow fixed impact:critical This issue should be addressed immediately due to a critical level of impact on the product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Security form fix nkhristinin/kibana
[8.3] Security form fix (#132834) elastic/kibana
5 participants
@peluja1012 @banderror @nkhristinin @elasticmachine @MadameSheema