Remove angular-translate #13066
Remove angular-translate #13066
Conversation
|
jenkins, test this |
|
The |
|
Same failure, must be related to these changed |
|
Great... |
epixa
force-pushed
the
removetranslations
branch
from
aed4b52 to
d879689
Compare
epixa
added
Team:Core
epixa
force-pushed
the
removetranslations
branch
4 times, most recently
from
459c3db to
89becdc
Compare
epixa
force-pushed
the
removetranslations
branch
from
89becdc to
2bf0fe1
Compare
|
This had a green build on the changes here before the yarn changes https://kibana-ci.elastic.co/job/elastic-kibana-pull-request/14573/ I pushed up a new commit that updates this PR for yarn. |
| @@ -16,9 +16,6 @@ function init() { | |||
|
|
|||
| debounce = $injector.get('debounce'); | |||
| debounceFromProvider = Private(DebounceProvider); | |||
|
|
|||
| // ensure there is a clean slate before testing deferred tasks | |||
| $timeout.flush(); | |||
There was a problem hiding this comment.
I don't think this needs to be removed?
There was a problem hiding this comment.
It does need to be removed. I'll be honestly, I'm not sure why exactly, but something angular-translate was doing required this. Prior to removing this, the tests failed with an error related to there being nothing to flush, and since this line was added in the original PR and tests now pass without it, it seemed unnecessary. If this was not a test file, I would have dug into it more to understand what's going on, but it just didn't feel worth digging deep into since my goal here is essentially to undo that original PR anyway.
* remove angular translate * remove angular-translate deps from yarn.lock
We're not abandoning the translation effort altogether, but we're
rolling back the angular-translate integration specifically as it has
too great of a negative effect on the dev experience. We'll revisit
template interpolation using a more component-oriented design.
This doc file was never actually included in docs in the first place,
so I just removed it rather than trying to rewrite it.