-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove translations from management section #13049
Conversation
For some reason the build has an error but it's not being reported. If you check the ci build you'll see:
|
We need to revisit how we embed translations into templates, so until we do we might as well go back to embedding text directly in the page. The translation implementation now makes it difficult to navigate throughout complicated HTML. It also suffers from an inability to flag on unused translation keys, which creates a good deal of technical debt. Close to half of all translation keys in the translation file in this initial pilot were already unused since it was introduced a couple of months ago.
5ffb89c
to
e090f78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stacey-gammon That failure is on master itself. Since the rest of the tests ran successfully, I'm going to move forward with this and work on the issue on master separately. @Bargs I'm going to do a followup that removes angular-translate, so I'll pull all the references to it in that. |
We need to revisit how we embed translations into templates, so until we do we might as well go back to embedding text directly in the page. The translation implementation now makes it difficult to navigate throughout complicated HTML. It also suffers from an inability to flag on unused translation keys, which creates a good deal of technical debt. Close to half of all translation keys in the translation file in this initial pilot were already unused since it was introduced a couple of months ago.
5.x 4acaf61 |
We need to revisit how we embed translations into templates, so until we
do we might as well go back to embedding text directly in the page. The
translation implementation now makes it difficult to navigate throughout
complicated HTML.
It also suffers from an inability to flag on unused translation keys,
which creates a good deal of technical debt. Close to half of all
translation keys in the translation file in this initial pilot were
already unused since it was introduced a couple of months ago.