Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.2.1] [Session view] Fix timestamps format #130568

Merged
merged 2 commits into from
Apr 25, 2022
Merged

[8.2.1] [Session view] Fix timestamps format #130568

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a353da
fix Session View timestamps format
opauloh Apr 19, 2022
79f7cf1
Merge branch 'main' into fix-session-view-timestamps
opauloh Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/session_view/common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export const PROCESS_EVENTS_INDEX = 'logs-endpoint.events.process-*';
export const PREVIEW_ALERTS_INDEX = '.preview.alerts-security.alerts-default';
export const ENTRY_SESSION_ENTITY_ID_PROPERTY = 'process.entry_leader.entity_id';
export const ALERT_UUID_PROPERTY = 'kibana.alert.uuid';
export const KIBANA_DATE_FORMAT = 'MMM DD, YYYY @ hh:mm:ss.SSS';
export const KIBANA_DATE_FORMAT = 'MMM DD, YYYY @ HH:mm:ss.SSS';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think eventually this should come from the user configurable global kibana setting, example can be found here https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/public/common/lib/kibana/hooks.ts#L27

Copy link
Contributor Author

@opauloh opauloh Apr 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, I will add that in our backlog for us to improve later, thanks!

export const ALERT_STATUS = {
OPEN: 'open',
ACKNOWLEDGED: 'acknowledged',
Expand Down