[8.2.1] [Session view] Fix timestamps format #130568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opauloh
added
release_note:skip
| @@ -13,7 +13,7 @@ export const PROCESS_EVENTS_INDEX = 'logs-endpoint.events.process-*'; | |||
| export const PREVIEW_ALERTS_INDEX = '.preview.alerts-security.alerts-default'; | |||
| export const ENTRY_SESSION_ENTITY_ID_PROPERTY = 'process.entry_leader.entity_id'; | |||
| export const ALERT_UUID_PROPERTY = 'kibana.alert.uuid'; | |||
| export const KIBANA_DATE_FORMAT = 'MMM DD, YYYY @ hh:mm:ss.SSS'; | |||
| export const KIBANA_DATE_FORMAT = 'MMM DD, YYYY @ HH:mm:ss.SSS'; | |||
There was a problem hiding this comment.
I think eventually this should come from the user configurable global kibana setting, example can be found here https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/public/common/lib/kibana/hooks.ts#L27
There was a problem hiding this comment.
good point, I will add that in our backlog for us to improve later, thanks!
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @opauloh |
opauloh
added
Team: AWP: Visualization
kibanamachine
pushed a commit
that referenced
this pull request
Apr 25, 2022
(cherry picked from commit dd5b807)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 25, 2022
(cherry picked from commit dd5b807) Co-authored-by: Paulo Henrique <[email protected]>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it fixes #130563
Summary
Update Timestamp format to use a 00 to 23 Hour range, so users can distinguish between an AM or PM Time.
Screenshots
Process on Session View (15:42:31):
Same process on Discover (15:42:31):
