-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cases] Limit the number of alerts that can be attached to a case #129988
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/response-ops-cases (Feature:Cases) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Can you add the following tests?:
- Fail when the case already has 1k alerts or more
- Fail when the case already has alerts and the sum of existing and new cases exceed 1k
Thanks! I don't understand the second bullet. The limit is per case not between all cases. |
💚 Build SucceededMetrics [docs]Public APIs missing comments
History
To update your PR or re-run it, just comment with: cc @cnasikas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the extra tests!
Summary
This PR adds a limit to the maximum number of alerts that can be attached to a case. The limit is set to 1K and is applied to a) the total number of alerts attached to a case and b) the total number of alerts that can be saved in the doc of the
cases-comments
saved object.Depends on #129092
Checklist
Delete any items that are not applicable to this PR.
For maintainers