PR feedback

elastic · Apr 14, 2022 · 4fcce3d · 4fcce3d
1 parent 31c2b8c
commit 4fcce3d
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 9 deletions.
diff --git a/x-pack/test/cases_api_integration/security_and_spaces/tests/common/comments/post_comment.ts b/x-pack/test/cases_api_integration/security_and_spaces/tests/common/comments/post_comment.ts
@@ -307,9 +307,26 @@ export default ({ getService }: FtrProviderContext): void => {
         });
       });
 
-      it('400s when attempting to add more than 1K alerts to a case in multiple calls', async () => {
+      it('400s when attempting to add an alert to a case that already has 1K alerts', async () => {
         const alerts = [...Array(1000).keys()].map((num) => `test-${num}`);
         const postedCase = await createCase(supertest, postCaseReq);
+        await createComment({
+          supertest,
+          caseId: postedCase.id,
+          params: { ...postCommentAlertReq, alertId: alerts, index: alerts },
+        });
+
+        await createComment({
+          supertest,
+          caseId: postedCase.id,
+          params: { ...postCommentAlertReq, alertId: 'test-id', index: 'test-index' },
+          expectedHttpCode: 400,
+        });
+      });
+
+      it('400s when the case already has alerts and the sum of existing and new alerts exceed 1k', async () => {
+        const alerts = [...Array(1200).keys()].map((num) => `test-${num}`);
+        const postedCase = await createCase(supertest, postCaseReq);
         await createComment({
           supertest,
           caseId: postedCase.id,
@@ -328,12 +345,6 @@ export default ({ getService }: FtrProviderContext): void => {
             alertId: alerts.slice(500),
             index: alerts.slice(500),
           },
-        });
-
-        await createComment({
-          supertest,
-          caseId: postedCase.id,
-          params: postCommentAlertReq,
           expectedHttpCode: 400,
         });
       });

diff --git a/...ases_api_integration/security_and_spaces/tests/common/internal/bulk_create_attachments.ts b/...ases_api_integration/security_and_spaces/tests/common/internal/bulk_create_attachments.ts
@@ -407,9 +407,38 @@ export default ({ getService }: FtrProviderContext): void => {
         });
       });
 
-      it('400s when attempting to add more than 1K alerts in multiple request', async () => {
+      it('400s when attempting to add an alert to a case that already has 1K alerts', async () => {
         const alerts = [...Array(1000).keys()].map((num) => `test-${num}`);
         const postedCase = await createCase(supertest, postCaseReq);
+        await bulkCreateAttachments({
+          supertest,
+          caseId: postedCase.id,
+          params: [
+            {
+              ...postCommentAlertReq,
+              alertId: alerts,
+              index: alerts,
+            },
+          ],
+        });
+
+        await bulkCreateAttachments({
+          supertest,
+          caseId: postedCase.id,
+          params: [
+            {
+              ...postCommentAlertReq,
+              alertId: 'test-id',
+              index: 'test-index',
+            },
+          ],
+          expectedHttpCode: 400,
+        });
+      });
+
+      it('400s when the case already has alerts and the sum of existing and new alerts exceed 1k', async () => {
+        const alerts = [...Array(1200).keys()].map((num) => `test-${num}`);
+        const postedCase = await createCase(supertest, postCaseReq);
         await bulkCreateAttachments({
           supertest,
           caseId: postedCase.id,
@@ -420,7 +449,6 @@ export default ({ getService }: FtrProviderContext): void => {
               index: alerts.slice(0, 500),
             },
           ],
-          expectedHttpCode: 200,
         });
 
         await bulkCreateAttachments({