[Cloud Posture] add findings framework sources icons #129883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orouz
added
release_note:skip
orouz
force-pushed
the
findings_framework_icons
branch
from
f17fefb to
9689f44
Compare
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Unknown metric groupsmiscellaneous assets size
To update your PR or re-run it, just comment with: |
orouz
commented
Apr 11, 2022
Comment on lines
+31
to
+32
| import cisLogoIcon from '../../assets/icons/cis_logo.svg'; | ||
| import k8sLogoIcon from '../../assets/icons/k8s_logo.svg'; |
There was a problem hiding this comment.
the figma design includes png for both icons, but they're common so i used svg i found
this also works well with EuiIcon which accepts custom svgs
if this is a mistake, LMK
ari-aviran
approved these changes
Apr 12, 2022
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security Posture) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds 2 icons (logos) under
public/assets/icons:and displays them under
Framework Sourcesin the findings flyout, on thegeneraltab