[Discover] Catch potental missing meta property of filter (#129183)

* Catching a potential error caused by a broken filter object without meta property

src/plugins/discover/public/application/main/components/layout/discover_layout.tsx

@@ -25,7 +25,7 @@ import { useDiscoverServices } from '../../../../utils/use_discover_services';
 import { DiscoverNoResults } from '../no_results';
 import { LoadingSpinner } from '../loading_spinner/loading_spinner';
 import { generateFilters } from '../../../../../../data/public';
-import { DataViewField } from '../../../../../../data_views/public';
+import { DataView, DataViewField, DataViewType } from '../../../../../../data_views/public';
 import { DiscoverSidebarResponsive } from '../sidebar';
 import { DiscoverLayoutProps } from './types';
 import { SEARCH_FIELDS_FROM_SOURCE, SHOW_FIELD_STATISTICS } from '../../../../../common';
@@ -48,7 +48,7 @@ import {
 import { FieldStatisticsTable } from '../field_stats_table';
 import { VIEW_MODE } from '../../../../components/view_mode_toggle';
 import { DOCUMENTS_VIEW_CLICK, FIELD_STATISTICS_VIEW_CLICK } from '../field_stats_table/constants';
-import { DataViewType, DataView } from '../../../../../../data_views/public';
+import { hasActiveFilter } from './utils';
 
 /**
  * Local storage key for sidebar persistence state
@@ -293,9 +293,7 @@ export function DiscoverLayout({
                   data={data}
                   error={dataState.error}
                   hasQuery={!!state.query?.query}
-                  hasFilters={
-                    state.filters && state.filters.filter((f) => !f.meta.disabled).length > 0
-                  }
+                  hasFilters={hasActiveFilter(state.filters)}
                   onDisableFilters={onDisableFilters}
                 />
               )}

src/plugins/discover/public/application/main/components/layout/utils.test.ts

@@ -0,0 +1,51 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+import { Filter } from '@kbn/es-query';
+import { hasActiveFilter } from './utils';
+
+const testFilter: Filter = {
+  meta: {
+    alias: null,
+    disabled: false,
+    negate: false,
+  },
+  query: { query: 'hi' },
+};
+const testFilterDisabled: Filter = {
+  meta: {
+    alias: null,
+    disabled: true,
+    negate: false,
+  },
+  query: { query: 'hi' },
+};
+
+const testFilterBroken = {} as Filter;
+
+describe('hasActiveFilter', () => {
+  test('only active filters', () => {
+    const filters = [testFilter];
+    const result = hasActiveFilter(filters);
+    expect(result).toBe(true);
+  });
+  test('only disabled filters', () => {
+    const filters = [testFilterDisabled];
+    const result = hasActiveFilter(filters);
+    expect(result).toBe(false);
+  });
+  test('disabled and active filters', () => {
+    const filters = [testFilter, testFilterDisabled];
+    const result = hasActiveFilter(filters);
+    expect(result).toBe(true);
+  });
+  test('broken filter - edge case', () => {
+    const filters = [testFilterBroken];
+    const result = hasActiveFilter(filters);
+    expect(result).toBe(true);
+  });
+});

src/plugins/discover/public/application/main/components/layout/utils.ts

@@ -0,0 +1,15 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0 and the Server Side Public License, v 1; you may not use this file except
+ * in compliance with, at your election, the Elastic License 2.0 or the Server
+ * Side Public License, v 1.
+ */
+import { Filter } from '@kbn/es-query';
+
+/**
+ * Returns if true there's at least 1 active filter
+ */
+export function hasActiveFilter(filters: Filter[] | undefined) {
+  return filters && filters.filter((f) => !f.meta?.disabled).length > 0;
+}