[Discover] Catch potental missing meta of filter #129183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
added
ci:deploy-cloud
Team:DataDiscovery
|
@elasticmachine merge upstream |
kertal
added
Feature:Discover
kertal
changed the title
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
kertal
added
the
release_note:skip
kertal
commented
Apr 11, 2022
Comment on lines
+46
to
+50
| test('broken filter - edge case', () => { | ||
| const filters = [testFilterBroken]; | ||
| const result = hasActiveFilter(filters); | ||
| expect(result).toBe(true); | ||
| }); |
There was a problem hiding this comment.
this is the test that actually would the original issue of having a broken filter object
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @kertal |
jughosta
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The issue of #126464 (broken filter object led to an exception when no data was found) was discovered in 7.15.1 and was not reproducible in recent Kibana version (>= 7.17). However, looking at the code that failed due to a broken filter object missing the
metaproperty, this PR improves the functionality that led to the problem in #126464. So, just in case Discover retrieves a broken Filter object again, it won't fail.Fixes #126464
Testing
There's no known way to manually test this, since AFAIK the problem with broken Filters no longer exists, so there's a unit test responsible for testing.
Checklist