Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a performance test for Discover with many fields #129464

Merged
merged 6 commits into from
Apr 14, 2022
Merged

Add a performance test for Discover with many fields #129464

merged 6 commits into from
Apr 14, 2022

Conversation

danielmitterdorfer
Copy link
Member

@danielmitterdorfer danielmitterdorfer commented Apr 5, 2022 •
edited
Loading

Summary

With this commit we add a performance test for the Discover view that measures
performance for a set of documents with many fields. The (new) dataset contains
50 documents based on the Elasticsearch indices stats API of an empty Elastic
Cloud cluster. Each document defines around 5000 properties.

Closes #126687

For maintainers

@danielmitterdorfer
Add a dataset with many fields for functional tests
a599564 
With this commit we add a new dataset that can be used in functional
tests. The dataset is contains 50 documents based on the Elasticsearch
indices stats API of an empty cluster. Each document defines around 5000
properties. It can be used to check rendering performance e.g. in the
discover view.

Closes elastic#126687
@danielmitterdorfer danielmitterdorfer added Team:Operations Team label for Operations Team release_note:skip Skip the PR/issue when compiling release notes Feature:Functional Testing v8.2.0 v8.3.0 labels Apr 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger
Copy link
Contributor

spalger commented Apr 7, 2022

@danielmitterdorfer do we have plans to write such tests? Can we add the dataset at the same time it's actually used?

@danielmitterdorfer danielmitterdorfer changed the title Add a dataset with many fields for functional tests Add a performance test for Discover with many fields Apr 13, 2022
@danielmitterdorfer
Copy link
Member Author

@spalger I've added a performance test in bc8a8e0 that uses this data set.

spalger
spalger approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@suchcodemuchwow
Copy link
Contributor

In order to run the tests hourly in CI we have to add journey name like here https://github.com/elastic/kibana/blob/main/.buildkite/scripts/steps/functional/performance_playwright.sh @danielmitterdorfer

@suchcodemuchwow
Copy link
Contributor

LGTM 😊🥳

@danielmitterdorfer danielmitterdorfer requested a review from a team as a code owner April 14, 2022 07:24
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @danielmitterdorfer

@danielmitterdorfer danielmitterdorfer merged commit 9fb1b06 into elastic:main Apr 14, 2022
@danielmitterdorfer danielmitterdorfer deleted the many-fields-dataset branch April 14, 2022 11:22
@spalger spalger mentioned this pull request Apr 14, 2022
Closed
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 129464 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 18, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 129464 or prevent reminders by adding the backport:skip label.

@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Apr 19, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.2 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.2:
- add login journey (#129976)
- Performance Test service and config refactor (#128258)

Manual backport

To create the backport manually run:

node scripts/backport --pr 129464

Questions ?

Please refer to the Backport tool documentation

@spalger spalger removed auto-backport Deprecated - use backport:version if exact versions are needed v8.2.0 labels Apr 19, 2022
@kibanamachine kibanamachine added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suchcodemuchwow suchcodemuchwow suchcodemuchwow approved these changes

@spalger spalger spalger approved these changes

@mshustov mshustov Awaiting requested review from mshustov

Assignees

@danielmitterdorfer danielmitterdorfer

Labels
backport:skip This commit does not require backporting Feature:Functional Testing release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create dataset for Discover app performance testing
6 participants
@danielmitterdorfer @elasticmachine @spalger @suchcodemuchwow @kibana-ci @kibanamachine